After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581727 - [playbin2] make playsink go to PAUSED async
[playbin2] make playsink go to PAUSED async
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-07 11:18 UTC by Wim Taymans
Modified: 2009-05-07 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to make playsink async (2.88 KB, patch)
2009-05-07 11:20 UTC, Wim Taymans
committed Details | Review

Description Wim Taymans 2009-05-07 11:18:50 UTC
playbin2 currently relies on uridecodebin to go to PAUSED async but in the case of DVD, uridecodebin takes some shortcuts and does not do the async magic.

It would be better for the playsink bin to perform an async state change until the real sinks are plugged and configured.

A patch follows.
Comment 1 Wim Taymans 2009-05-07 11:20:03 UTC
Created attachment 134183 [details] [review]
patch to make playsink async

this patch makes playsink go async to PAUSED until the sinks are configured and take over.

this avoids the pipeline going to PLAYING before the sinks are plugged and have a chance to provide a clock.
Comment 2 Wim Taymans 2009-05-07 12:30:36 UTC
commit c05541c19505cf52f4e76fcc27f2b85328e5660b
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Thu May 7 14:28:30 2009 +0200

    playbin2: make playsink go ASYNC to PAUSED
    
    Make playsink go async to the PAUSED state instead of relying on uridecodebin
    for async behaviour in playbin. This solves some problems (mainly with DVD)
    where the pipeline would go to PLAYING before preroll completed, failing to
    select the audiosink clock.
    Fixes #581727
Comment 3 Wim Taymans 2009-05-07 13:27:11 UTC
commit 52da312fa5368421ae63a2963533e7e14f1cb415
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Thu May 7 15:19:05 2009 +0200

    playsink: initialize variable too