GNOME Bugzilla – Bug 581648
Wrong Dependency Version(s) in “configure.in”
Last modified: 2009-06-08 19:31:23 UTC
The minimum required GTK+ version that is stated in “configure.in” (from Git master) is currently 2.12.0. However, gthumb is using at least one function from GTK+ 2.14 (gtk_show_uri). Therefore compiling gthumb didn’t work for me with GTK+ 2.12. Compiling with GTK+ 2.20 works fine. I suspect that the GLib version requirement is wrong, too – I couldn’t test this, though. But probably GTK+ already needs a higher version than the stated 2.6.0. By the way: some compiler warning flags that were added with commit 1420191515177a681326c4524b20375c96e14aa4 to libgthumb/Makefile.am and src/Makefile.am (namely -Wtype-limits, -Wclobbered, -Wempty-body and -Wignored-qualifiers) probably require a higher gcc version than 4.2.4 which I am using here. I could only compile gthumb after removing these flags. If there is any way to specify the minimum gcc version or the minimally required compiler flags in the configure script, then this should perhaps be done. Another option could be to use -Wextra instead: if I understand it correctly, this flag summarizes the new flags but – other than the new flags themselves – -Wextra is already supported by gcc 4.2.4. Compiling with the above mentioned flags replaced with -Wextra in the Makefiles worked flawlessly for me.
The gtk requirement has already been bumped. -Wextra generates too many unused parameter warnings. I'm not sure what to do here... - Mike
Rhythmbox is using a mechanism to detect if the compiler support a -W option or not. You can have a look at it here: http://git.gnome.org/cgit/rhythmbox/tree/configure.ac I think we could reuse the same code for gthumb. I will try to do it when I have time. Marc
Created attachment 135622 [details] [review] Check compilation warnings This patch should fix the warnings issue described in the bug. configure now checks that gcc supports a warning before using it. Marc
Oops, I missed this. Committed, thanks! - Mike