GNOME Bugzilla – Bug 581424
Personal folder tree appears besides Public folder when you go to Folder > Subscription
Last modified: 2009-05-26 10:17:36 UTC
Evolution 2.27.1 Folder > Subscription > Exchange account should display only public folder list.
Created attachment 134003 [details] Screen shot
Confirming.
happens with evolution-mapi also.
@@ -357,7 +356,7 @@ sub_folderinfo_exec (struct _emse_folderinfo_msg *m) if (m->seq == m->sub->seq) { camel_operation_register(m->base.cancel); - m->info = camel_store_get_folder_info(m->sub->store, m->node?m->node->info->full_name:pub_full_name, CAMEL_STORE_FOLDER_INFO_FAST | CAMEL_STORE_FOLDER_INFO_NO_VIRTUAL, &m->base.ex); + m->info = camel_store_get_folder_info(m->sub->store, m->node?m->node->info->full_name:pub_full_name, CAMEL_STORE_FOLDER_INFO_NO_VIRTUAL, &m->base.ex); camel_operation_unregister(m->base.cancel); } } http://git.gnome.org/cgit/evolution/diff/mail/em-subscribe-editor.c?id=8a072ffc7c0ddcde472877a51ace0bb14f86fb0a (2nd hunk) Milan, Is that a valid hunk or a accidental commit ?
It is intended, because in camel-store.h: #ifndef CAMEL_DISABLE_DEPRECATED #define CAMEL_STORE_FOLDER_INFO_FAST (1 << 0) #endif /* CAMEL_DISABLE_DEPRECATED */ The only thing is that I gave up on the full removal of this, because it's on too many places, and the main focus of the bug were gtk+ deprecated symbols.
7bd222111978bf224554f835e1a3da57e682207e is the commit that deprecated those flags. http://git.gnome.org/cgit/evolution-data-server/commit/?id=7bd222111 evolution-exchange and evolution-mapi depends on INFO_FAST to fetch public folder hierarchy. This was a bad assumption. But it is broken now.
I mentioned this to jony already on IRC, but the rationale for that comes from the camel_store_get_folder_info() documentation: The CAMEL_STORE_FOLDER_INFO_FAST flag should be considered deprecated; most backends will behave the same whether it is supplied or not. The only guaranteed way to get updated folder counts is to both open the folder and invoke refresh_info() it.
Created attachment 134143 [details] [review] Introduce a new folderinfo flag for subscription lists. If SUBSCRIPTION_LIST does not sound right please suggest a new name.
Created attachment 134144 [details] [review] Corresponding evolution change. Use SUBSCRIPTION_LIST when called from subscription editor.
Strange. I bet I had somewhere a fix which added some similar flag. Ahh, bug #413422 , still waiting its review.
Looks good to me. Commit to master. Wonder if NNTP could take advantage of that flag...
Patch committed. Reassigning to Bharath for owa connector changes.
Created attachment 135157 [details] [review] e-e patch
(In reply to comment #13) > Created an attachment (id=135157) [edit] > e-e patch > rename gboolean info_fast to subscription_list. And introduce a new stub flag.
Committed to master incorporating the review comments. http://git.gnome.org/cgit/evolution-exchange/commit/?id=7b927831a34203310a95bf5932844cceef6f92d4