After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581372 - [pending] Move cursor routing key and six dot key handling from braille.py to script
[pending] Move cursor routing key and six dot key handling from braille.py to...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
unspecified
Other opensolaris
: Normal normal
: 2.28.0
Assigned To: Willie Walker
Orca Maintainers
Depends on: 581352
Blocks: 354471
 
 
Reported: 2009-05-04 20:54 UTC by Willie Walker
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Work in progress (11.74 KB, patch)
2009-05-04 21:00 UTC, Willie Walker 		needs-work Details | Review
Revised patch (14.72 KB, patch)
2009-05-05 18:22 UTC, Willie Walker 		committed Details | Review

Description Willie Walker 2009-05-04 20:54:30 UTC 
Cursor routing keys and the six dot contracted braille key are currently handled inside braille.py.  This makes it very difficult for us to do things such as permit text selection from the braille display.

With bug #581352 fixed, we can now go ahead with this work.
Comment 1 Willie Walker 2009-05-04 21:00:36 UTC 
Created attachment 133969 [details] [review]
Work in progress

This is a work in progress that also migrates the code to be more in line with the BrlAPI API.  Seems to work nicely, though I need to give the SIX DOTS stuff some testing and figure out where the mysterious (0x2141, 65) numbers came from.
Comment 2 Willie Walker 2009-05-05 18:22:20 UTC 
Created attachment 134049 [details] [review]
Revised patch

This patch seems to work nicely and pylints well.  The new behavior of the six dots command seems to align better with BrlAPI as well -- with one dot pattern (2-3-5 on my Baum display), contracted braille is turned on whereas another dot pattern (2-3-6 on my Baum display), contracted braille is turned off.  This differs from toggling contracted braille with either pattern.  Committed to master.
Comment 3 Willie Walker 2009-05-08 15:22:08 UTC 
Closing as fixed.  Seems to work nicely.