GNOME Bugzilla – Bug 581300
removing C++ style comments from threadtests.c
Last modified: 2010-01-20 17:59:51 UTC
Hello, In the glib source, only this C source file contains C++ comments: gobject/tests/threadtests.c These lines are affected: $ grep -n "//" glib-2.20.1/gobject/tests/threadtests.c.bak 67: g_atomic_int_add (&mtsafe_call_counter, 1); // real call count update 68: g_thread_yield(); // let concurrent threads corrupt the unsafe_call_counter state 69: unsafe_call_counter = 1 + saved_unsafe_call_counter; // non-atomic counter update 172: ; // neds unit test framework initialization: g_test_bug ("race initializing properties"); It makes the IBM XL C Compiler (the 'native' non-free compiler on the AIX platform) stop compiling glib with syntax error. If you could remove or replace these comments, compilation would otherwise be error-free on these platforms: AIX 5.3 and 6.1. ;-) regards LGee
Created attachment 143817 [details] [review] Patch Here's the patch. Please review and apply
ping
Review of attachment 143817 [details] [review]: commit 7693b0af445645f09e55ed7cebe0051c3d1fdd8d
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.