After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581300 - removing C++ style comments from threadtests.c
removing C++ style comments from threadtests.c
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
2.23.x
Other AIX
: Normal major
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2009-05-04 12:02 UTC by Gabor LOCSEI
Modified: 2010-01-20 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (2.59 KB, patch)
2009-09-23 18:07 UTC, Alberto Garcia
committed Details | Review

Description Gabor LOCSEI 2009-05-04 12:02:30 UTC
Hello,

In the glib source, only this C source file contains C++ comments:

gobject/tests/threadtests.c

These lines are affected:

$ grep -n "//" glib-2.20.1/gobject/tests/threadtests.c.bak
67:      g_atomic_int_add (&mtsafe_call_counter, 1); // real call count update
68:      g_thread_yield(); // let concurrent threads corrupt the unsafe_call_counter state
69:      unsafe_call_counter = 1 + saved_unsafe_call_counter; // non-atomic counter update
172:    ; // neds unit test framework initialization: g_test_bug ("race initializing properties");

It makes the IBM XL C Compiler (the 'native' non-free compiler on the AIX platform) stop compiling glib with syntax error. If you could remove or replace these comments, compilation would otherwise be error-free on these platforms: AIX 5.3 and 6.1. ;-)

regards
LGee
Comment 1 Alberto Garcia 2009-09-23 18:07:23 UTC
Created attachment 143817 [details] [review]
Patch

Here's the patch. Please review and apply
Comment 2 Alberto Garcia 2010-01-20 17:18:38 UTC
ping
Comment 3 Javier Jardón (IRC: jjardon) 2010-01-20 17:59:29 UTC
Review of attachment 143817 [details] [review]:

commit 7693b0af445645f09e55ed7cebe0051c3d1fdd8d
Comment 4 Javier Jardón (IRC: jjardon) 2010-01-20 17:59:51 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.