After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581295 - mp4mux: Add support for embedded subtitles
mp4mux: Add support for embedded subtitles
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.3.1
Assigned To: Thiago Sousa Santos
GStreamer Maintainers
: 696437 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-05-04 11:30 UTC by Christian Fredrik Kalager Schaller
Modified: 2014-09-28 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christian Fredrik Kalager Schaller 2009-05-04 11:30:00 UTC 
Seems the PS3 supports playing back MP4 files with embedded subtitles. Here
is an example of such files:
http://samples.mplayerhq.hu/MPEG-4/embedded_subs/
Comment 1 Thiago Sousa Santos 2009-05-10 15:56:19 UTC 
Talking to others in #gstreamer I found out that sparse streams (like subtitles) can't be muxed by current muxers that use GstCollectPads. GstCollectPads2 will be able to handle this, but it is not in core yet.
Comment 2 Mark Nauwelaerts 2012-10-24 10:31:03 UTC 
mp4mux in -good nowadays.
Comment 3 Edward Hervey 2013-08-13 18:44:37 UTC 
This bug has an assigned developer but has not received activity in almost a year.

Is the assigned person still working on this ?
Comment 4 Christian Fredrik Kalager Schaller 2014-02-03 12:08:51 UTC 
Thiago any chance you get to take a look at this? Or should we reset it to 'new' and unassigned?
Comment 5 Thiago Sousa Santos 2014-02-05 13:29:19 UTC 
Sorry for the delay, taking a look at this again
Comment 6 Thiago Sousa Santos 2014-02-07 16:39:18 UTC 
Fixed by these commits but neither the original nor the remuxed show subtitles on the PS3, only the audio and video.

commit 99e966e2e15c62608b742a1e6011d31b88358f20
Author: Thiago Santos <ts.santos@sisa.samsung.com>
Date:   Thu Feb 6 12:15:22 2014 -0300

    qtmux: add support for text/x-raw subtitles
    
    Adds it to mp4mux, qtmux and gppmux.
    
    Buffers need to be prefixed with 2 bytes for the text length before
    being muxed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=581295

commit d644cda79b2e2419a294942761c1090d3d66be27
Author: Thiago Santos <ts.santos@sisa.samsung.com>
Date:   Thu Feb 6 12:09:01 2014 -0300

    qtmux: add support for the TX3G atoms
    
    Adds functions for creating and setting values related to the
    tx3g atom for raw text subtitle support.
    
    QTFF spec has information on those atoms
    
    https://bugzilla.gnome.org/show_bug.cgi?id=581295

commit 2ae18972734cba00a3dc3559c5affbef8ba4f714
Author: Thiago Santos <ts.santos@sisa.samsung.com>
Date:   Wed Feb 5 10:27:54 2014 -0300

    qtmux: add subtitle support to qtmuxmap structures
    
    adds basic stubs for subtitle support around the qtmux and
    qtmuxmap structures. Still no real subtitle implemented, but
    basic functions in place
    
    https://bugzilla.gnome.org/show_bug.cgi?id=581295
Comment 7 Thiago Sousa Santos 2014-02-07 16:40:04 UTC 
If there is any sample that has subtitles on ps3 we can try and see if remuxing it works or if it needs support to another subtitle format. (On a separate bug, hopefully)
Comment 8 Matej Knopp 2014-09-21 15:18:07 UTC 
I'm a bit curious why you implemented this from scratch since there are working patches at #696437

Anyway, does your implementation handle overlapping buffers?
Comment 9 Matej Knopp 2014-09-28 12:04:34 UTC 
*** Bug 696437 has been marked as a duplicate of this bug. ***