After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581282 - Planner crashes when click on "Print Preview" and the project is empty
Planner crashes when click on "Print Preview" and the project is empty
Status: RESOLVED FIXED
Product: planner
Classification: Other
Component: Printing
0.14.x
Other All
: Normal critical
: ---
Assigned To: planner-maint
planner-maint
: 699179 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-05-04 09:44 UTC by NeMuX
Modified: 2013-04-29 07:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Temporarily Fix (955 bytes, patch)
2009-05-04 10:58 UTC, NeMuX
rejected Details | Review
One the possible solution for the problem (186 bytes, patch)
2012-06-10 01:39 UTC, Tiago Motta
rejected Details | Review
Don't crash on an empty print preview, just provide an empty preview. (1.19 KB, patch)
2013-03-11 00:04 UTC, Luis Menina
committed Details | Review

Description NeMuX 2009-05-04 09:44:49 UTC
When someone open Planner 0.14.4 and source code repository, and make click on "Print Preview" the program crashes.

I test in Windows (binary) Linux (Debian repositories) and Freebsd (ports) versions, and I also compile the program from the oficial tarball and svn version.
Comment 1 NeMuX 2009-05-04 10:58:16 UTC
Created attachment 133914 [details] [review]
Temporarily Fix

This is a little patch that prevent the application crashes when in an empty project selects "print preview"
Comment 2 Alexandre Franke 2009-09-23 13:48:26 UTC
I can confirm this problem. The above patch isn't a real solution, we'll need to investigate this.
Comment 3 Alexandre Franke 2010-10-18 15:55:13 UTC
Comment on attachment 133914 [details] [review]
Temporarily Fix

Not an appropriate solution.
Comment 4 Maxim Zakharov 2011-07-28 01:17:48 UTC
I think showing an empty page in this case could reduce the severity of the bug from critical to normal.

At least there is no better solution proposed yet during a year.
Comment 5 Tiago Motta 2012-06-10 01:39:56 UTC
Created attachment 216048 [details] [review]
One the possible solution for the problem
Comment 6 Luis Menina 2013-03-10 03:01:43 UTC
gtk_print_operation_set_n_pages documentation says that n_pages "must be set to a positive number before the rendering starts". So setting it to 0 in your patch won't work. Please follow the patch submission guidelines in the future, as patches need to be in a specific format:
http://live.gnome.org/GnomeLove/SubmittingPatches
Comment 7 Luis Menina 2013-03-11 00:04:13 UTC
Created attachment 238551 [details] [review]
Don't crash on an empty print preview, just provide an empty preview.
Comment 8 Alexandre Franke 2013-03-11 17:05:46 UTC
Comment on attachment 238551 [details] [review]
Don't crash on an empty print preview, just provide an empty preview.

Please push this and close the bug afterwards.
Comment 9 Luis Menina 2013-03-11 20:25:20 UTC
Attachment 238551 [details] pushed as 0cc65e2 - Don't crash on an empty print preview, just provide an empty preview.
Comment 10 Alexandre Franke 2013-04-29 07:06:27 UTC
*** Bug 699179 has been marked as a duplicate of this bug. ***