GNOME Bugzilla – Bug 581128
Various improvements
Last modified: 2009-05-03 08:34:52 UTC
Please describe the problem: Hi, I will use this bug to propose a few patches for small improvements. Marc Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 133821 [details] [review] Get authors from AUTHORS With this patch, Gthumbs gets the list of authors from AUTHORS file instead of hard code to avoid double maintenance.
Created attachment 133822 [details] [review] Remove gtk_object_sink Remove all calls to gtk_object_sink (deprecated)
Created attachment 133823 [details] [review] Remove GtkType Use GType instead of deprecated GtkType.
Created attachment 133824 [details] [review] Remove GtkOptionMenu Replace GtkOptionMenu (deprecated) by GtkComboBox in dlg-save-image.c. GtkOptionMenu is still widely used in other files but it's a first step.
Created attachment 133825 [details] [review] Remove call deprecated methods This patch removes a few calls to deprecated code (GtkTooltips, gdk_pixbuf_render_to_drawable, g_string_sprintf, gdk_pango_context_set_colormap, g_strcasecmp). It also fixes search in categories list by using default GTK implementation of search in Treeview.
Created attachment 133826 [details] [review] Remove eel-canvas-rect I'm not really sure about this last patch but eel-canvas-rect seems to not be used anymore so I think eel-canvas-rect.c and eel-canvas-rect.h could be removed. The patch removes them for Makefile.
AUTHORS patch committed - cool, it's nice to have a Makefile guru around. Some of the gtk stuff is also in bug 575017. - Mike
I didn't notice bug 575017 but yes, most of my patches are already proposed. The only remaining interesting one is "Remove GtkOptionMenu". (It's the less obvious patch). Marc
Hey buddy I don't think it is wise to create a bug report with title "Various improvements", like in this case, it is making we duplicate our effort, since it is does not appear when you're searching for something. Removing deprecated symbols task is almost done in #575017 bug, I suggest to close this bug and file a new bug for each new enhancement/improvement.