After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580946 - Should not use deprecated gtk symbols
Should not use deprecated gtk symbols
Product: GtkHtml
Classification: Other
Component: Editing
Other Linux
: Normal normal
: ---
Assigned To: Srinivasa Ragavan
Srinivasa Ragavan
Depends on:
Reported: 2009-04-30 21:49 UTC by Thomas Andersen
Modified: 2009-05-03 19:06 UTC
See Also:
GNOME target: 2.28.x
GNOME version: ---

Replace deprecated gtk symbol (8.77 KB, patch)
2009-04-30 22:15 UTC, Thomas Andersen
none Details | Review
Replace deprecated gtk symbol (v2) (8.90 KB, patch)
2009-04-30 22:58 UTC, Thomas Andersen
committed Details | Review

Description Thomas Andersen 2009-04-30 21:49:09 UTC
The following deprecated gtk symbols are found in the source of gtkhtml:
Comment 1 Thomas Andersen 2009-04-30 22:15:35 UTC
Created attachment 133694 [details] [review]
Replace deprecated gtk symbol

The patch replaces the deprecated api and bumps gtk dep to 2.16
Comment 2 Thomas Andersen 2009-04-30 22:58:07 UTC
Created attachment 133702 [details] [review]
Replace deprecated gtk symbol (v2)

Whoops. That was a bad patch.

This one is the same but without me being stupid. Sorry
Comment 3 André Klapper 2009-05-01 10:13:39 UTC
I definitely do expect those gtkhtml maintainers that work for Novell to refuse a patch that bumps the GTK+ requirement to 2.16 because Novell *managers* will bitch about this, driven by the stupid idea to be able to ship a more recent Evolution version for some ancient stone-aged GNOME versions included in their SLED-whatever.
This blocks progress in GNOME, is quite selfish of Novell (taking upstream GNOME as a hostage just because Novell is too lazy to manage their own patchsets against upstream internally) and shows missing understanding of the GNOME concept (the synchronized version numbers exist for a reason - Evolution 2.26 should never be meant to run on GNOME 2.22).

Hence I should maybe just commit this.
Comment 4 Thomas Andersen 2009-05-01 10:39:05 UTC
wow, this really sucks.

I'll provide yet another ifdef-based patch then. The code will be a bit more messy but that is not my headache.
Comment 5 André Klapper 2009-05-01 11:45:31 UTC
Great. Looks like the situation changed. Big thanks to Novell.
--> Commit to master. :)
Comment 6 Srinivasa Ragavan 2009-05-01 12:40:08 UTC
Yep, I was about to comment that. 
Comment 7 Thomas Andersen 2009-05-03 19:06:39 UTC
Committed to master: