GNOME Bugzilla – Bug 580900
Kill libgnomeui/gnome-dateedit
Last modified: 2009-05-06 17:30:33 UTC
http://live.gnome.org/LibgnomeMustDie ./e-util/e-dialog-widgets.c:#include <libgnomeui/gnome-dateedit.h> ./calendar/gui/e-meeting-time-sel.c:#include <libgnomeui/gnome-dateedit.h>
Don't think we have a replacement for this yet in GTK+.
<mclasen> first of all, I'd check how widely used the remaining parts are <mclasen> no need to invest time in something thats barely used <mclasen> I'm pretty sure evolution has its own date/time editing controls, e.g <andre> according to my files here, "gnome_date_edit_" only exists in gnome-sharp and evolution. <kmaraas> ok, so evolution is actually using it <kmaraas> same result here - except the bindings and glade of course ...hence no need for GTK+ replacements.
I guess we'll be adopting GnomeDateEdit then? More legacy shit to maintain...
Created attachment 133988 [details] [review] Stop libgnome from dating Correct me if I'm naive and young, but I couldn't find anything actually USING those functions. Was Evolution designed to use its own E_DATE_EDIT stuff long ago? Evo compiles fine with the attached patch (against 2.26.0).
Same results here. $:andre\> cd svn-gnome/evolution $:andre\> grep -r e_dialog_dateedit_ . ./e-util/e-dialog-widgets.c: * e_dialog_dateedit_set: ./e-util/e-dialog-widgets.c:e_dialog_dateedit_set (GtkWidget *widget, time_t t) ./e-util/e-dialog-widgets.c: * e_dialog_dateedit_get: ./e-util/e-dialog-widgets.c:e_dialog_dateedit_get (GtkWidget *widget) ./e-util/e-dialog-widgets.h:void e_dialog_dateedit_set (GtkWidget *widget, time_t t); ./e-util/e-dialog-widgets.h:time_t e_dialog_dateedit_get (GtkWidget *widget); ./e-util/ChangeLog: * e-dialog-widget.c (e_dialog_dateedit_get): ./e-util/ChangeLog.pre-1-4: (e_dialog_dateedit_set): Likewise. ./e-util/ChangeLog.pre-1-4: (e_dialog_dateedit_get): Likewise. $:andre\>
I'd suspect that something like /widgets/misc/e-dateedit.c is used nowadays instead.
Oh awesome, I guess I should have checked for that to begin with. Patch looks good; commit to master. Thanks, Adam.
Committed Adam's patch to master in http://git.gnome.org/cgit/evolution/commit/?id=dfb0db749801075ba67e24ac44de8fe9ac2ae2cc