After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580760 - Allow compositor to see ButtonPress events for buttons 4 and 5 (scroll wheel)
Allow compositor to see ButtonPress events for buttons 4 and 5 (scroll wheel)
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2009-04-29 15:13 UTC by Tomas Frydrych
Modified: 2009-05-05 08:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to pass ButtonPress 4 and 5 to compositor. (1.70 KB, patch)
2009-04-29 15:14 UTC, Tomas Frydrych 		none Details | Review
Illustrative patch (1.12 KB, patch)
2009-04-29 16:05 UTC, Owen Taylor 		none Details | Review

Description Tomas Frydrych 2009-04-29 15:13:46 UTC 
At present the scroll wheel events are filtered out; this might be of interest to compositor plugins.
Comment 1 Tomas Frydrych 2009-04-29 15:14:37 UTC 
Created attachment 133570 [details] [review]
Patch to pass ButtonPress 4 and 5 to compositor.
Comment 2 Owen Taylor 2009-04-29 16:05:09 UTC 
Conceptually this looks good to me, but it certainly doesn't make the flow of that function any easier to understand. Could you instead remove the early return and check for scroll wheel events where Metacity goes ahead and processes button presses? I'll attach a completely untested patch to show what I mean.
Comment 3 Owen Taylor 2009-04-29 16:05:53 UTC 
Created attachment 133576 [details] [review]
Illustrative patch
Comment 4 Tomas Frydrych 2009-05-05 08:53:13 UTC 
Committed as 90c35f8181e5fdc10e70fe7aa17d055ce3aada48.