After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580622 - xml dir is both part of distclean and dist rules
xml dir is both part of distclean and dist rules
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.11
Other Linux
: Normal normal
: 1.12
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-28 16:07 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-04-29 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-04-28 16:07:05 UTC
distclean shouldn't remove things that are part of the dist tarball. gtk-doc.make.notmpl does not have the bg and it also seems to be ancient change in the original gtk-doc.make.

I'd propose to not dist the xml files at all.

28fde951 (James Henstridge 2003-02-12 12:51:12 +0000 181) dist-hook: dist-check-gtkdoc dist-hook-local
28fde951 (James Henstridge 2003-02-12 12:51:12 +0000 182)       mkdir $(distdir)/tmpl
28fde951 (James Henstridge 2003-02-12 12:51:12 +0000 183)       mkdir $(distdir)/xml
28fde951 (James Henstridge 2003-02-12 12:51:12 +0000 184)       mkdir $(distdir)/html
28fde951 (James Henstridge 2003-02-12 12:51:12 +0000 185)       -cp $(srcdir)/tmpl/*.sgml $(distdir)/tmpl
28fde951 (James Henstridge 2003-02-12 12:51:12 +0000 186)       -cp $(srcdir)/xml/*.xml $(distdir)/xml
3eb88036 (Damon Chaplin    2007-01-04 13:22:40 +0000 187)       cp $(srcdir)/html/* $(distdir)/html
e4ca53bd (Stefan Kost      2008-01-17 13:16:45 +0000 188)       -cp $(srcdir)/$(DOC_MODULE).types $(distdir)/
e4ca53bd (Stefan Kost      2008-01-17 13:16:45 +0000 189)       -cp $(srcdir)/$(DOC_MODULE)-sections.txt $(distdir)/
3910d237 (Stefan Kost      2007-09-24 19:31:03 +0000 190)       cd $(distdir) && rm -f $(DISTCLEANFILES)
ef5f56ca (Stefan Kost      2009-01-07 16:04:30 +0000 191)       $(GTKDOC_REBASE) --online --relative --html-dir=$(distdir)/html
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2009-04-29 11:17:22 UTC
commit 42600037ce1f4daa3dd1e1a6f13b9f6e0adf69a6
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Wed Apr 29 14:08:21 2009 +0300

    make: don't dist xml dir. Fixes #580622
    
    Distclean shouldn't remove things that are part of the dist tarball.