After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580556 - Resync with libegg to remove deprecated GTK+ symbols
Resync with libegg to remove deprecated GTK+ symbols
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks: 585692
Reported: 2009-04-28 08:01 UTC by Thomas Andersen
Modified: 2009-06-13 23:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Replace deprecated gtk symbols (1.51 KB, patch)
2009-04-28 15:38 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Thomas Andersen 2009-04-28 08:01:37 UTC
Evince uses the deprecated gtk_widget_get_action in copy-pasted code from ligegg:

cut-n-paste/toolbar-editor/egg-editable-toolbar.c:203:  action = gtk_widget_get_action (widget);
cut-n-paste/toolbar-editor/egg-editable-toolbar.c:229:      action = gtk_widget_get_action (widget);
cut-n-paste/toolbar-editor/egg-editable-toolbar.c:500:  GtkAction *action = gtk_widget_get_action (GTK_WIDGET (item));

The replacement gtk_activatable_get_related_action requires gtk 2.16 and libegg has added a check to use it if the available gtk version is high enough.

You should resync with libegg to get that code. The relevant commit it here:
Comment 1 Javier Jardón (IRC: jjardon) 2009-04-28 15:38:48 UTC
Created attachment 133511 [details] [review]
Replace deprecated gtk symbols
Comment 2 Nickolay V. Shmyrev 2009-04-30 08:47:18 UTC
Applied, thanks a lot!