Bug 580149 - drop libglade dependency; use GtkBuilder
drop libglade dependency; use GtkBuilder
Status: RESOLVED FIXED
Product: gnome-nettool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Germán Poo-Caamaño
Rodrigo Moya
:
Depends on:
Blocks: 572883
  Show dependency tree
 
Reported: 2009-04-24 17:20 UTC by Pedro Fragoso
Modified: 2009-07-14 04:23 UTC (History)
3 users (show)

See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
proposed patch (27.23 KB, patch)
2009-04-24 17:24 UTC, Pedro Fragoso 		none Details | Diff | Review
proposed patch (312.19 KB, patch)
2009-04-24 18:06 UTC, Pedro Fragoso 		needs-work Details | Diff | Review
Updated gtk-builder patch (313.21 KB, patch)
2009-07-12 12:57 UTC, Jaap A. Haitsma 		committed Details | Diff | Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Comment 1 Pedro Fragoso 2009-04-24 17:24:47 UTC 
Created attachment 133267 [details] [review]
proposed patch
Comment 2 Pedro Fragoso 2009-04-24 18:06:48 UTC 
Created attachment 133270 [details] [review]
proposed patch
Comment 3 Germán Poo-Caamaño 2009-05-04 04:41:22 UTC 
May you update your patch against master?
Comment 4 Jaap A. Haitsma 2009-07-12 12:57:45 UTC 
Created attachment 138270 [details] [review]
Updated gtk-builder patch

OK to commit to git?

BTW the glade file that currently is in git contains an error and gnome-nettool did not startup because of that. Also glade-3 did not want to load the file. I fixed that error before converting it to a gtkbuilder file
Comment 5 Germán Poo-Caamaño 2009-07-13 17:51:47 UTC 
Please commit it on master and close this bug.
Comment 6 Jaap A. Haitsma 2009-07-14 04:23:48 UTC 
commit 369c2ccf74ede8b3fa6ad334829ba872e2f78bff
Author: Jaap A. Haitsma <jaap@haitsma.org>
Date:   Sun Jul 12 14:47:43 2009 +0200

    Use gtkbuilder iso libglade
    
    Fixes bug #580149
    Based on patch of Pedro Fragoso <ember@ubuntu.com>
Note You need to log in before you can comment on or make changes to this bug.