After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580096 - In "Save As" dialog with folder selected, "Save" doesn't save
In "Save As" dialog with folder selected, "Save" doesn't save
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
3.22.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
filechooser-beginner-fix
: 793307 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-04-24 09:50 UTC by Matthew Paul Thomas (mpt)
Modified: 2018-05-02 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthew Paul Thomas (mpt) 2009-04-24 09:50:52 UTC
1.  From any program that has a "Save As" command, choose "Save As".
2.  In the Save As dialog, click on a folder in the main file listing.
3.  Click "Save".

What happens: The selected folder opens in the dialog. The file is not saved.

What should happen: Either the button should save the file, or it should not be labelled "Save".

The Save dialog in Windows, while mostly a trainwreck, avoids this particular error by changing the "Save" button to "Open" whenever a folder is selected.
Comment 1 Troy Sankey 2012-05-19 04:38:38 UTC
If a directory is selected, it cannot be deselected by clicking on whitespace. This "Open" functionality with selected directories is particularly annoying if you can't even deselect the folder.
Comment 2 Timothy Arceri 2013-06-29 01:42:00 UTC
This bug should be pretty straight forward to fix. Change the 'Save' text to 'Open' when a selection signal is given and a folder is selected and change back to 'Save' if a file is selected. A check would also need to be done first to see if the filechooser is in Save mode.  

While the issue in comment 1 is indeed valid it should be addressed in a separate bug. I'm sure there is probably an existing bug about it somewhere.
Comment 3 Matt Morgan 2015-10-14 00:45:59 UTC
There is a broader issue here. When you click any directory, focus gets messed up, too. So, for example:

1. Open the Save As Dialog to save a file.
2. Click into the directory where you want to save the file.
3. Start typing the new name of the file.

The filename has focus (is highlighted) and therefore should be replaced by the typed characters. But instead, a mystery text-entry box appears and starts accepting the characters. It's unclear what this box does, if anything.

Either the text in the filename box should lose focus, or typing should replace it.
Comment 4 Daniel Boles 2017-08-29 23:40:34 UTC
Comment 2: agreed

Comment 3: different issue, see https://bugzilla.gnome.org/show_bug.cgi?id=770941
Comment 5 Mario Wenzel 2017-11-20 10:14:02 UTC
So this is still an issue. I had the same problem when I was trying to save a picture to a folder with no pictures yet but some subfolders. I accidentally selected one of the folders and there was no way to unselect the folder.

"Save" put me into the subfolder. When I chose the parent folder again via the navbar, the subfolder was still selected. Clicking on whitespace didn't unselect the folder.

I had to use the left side navigation to go back to home and then re-navigate to the target folder, which is incredibly annoying behaviour.
Comment 6 Daniel Boles 2018-02-12 15:40:57 UTC
*** Bug 760699 has been marked as a duplicate of this bug. ***
Comment 7 Daniel Boles 2018-02-12 15:41:54 UTC
*** Bug 793307 has been marked as a duplicate of this bug. ***
Comment 8 Robert Orzanna 2018-02-12 16:13:59 UTC
Hey everyone, 

Coming from [1] and would like to suggest that if you go up the folder hierarchy, then maybe it should unselect any previously selected folder to prevent the case from users accidentally ending up in an unintended subfolder where they don't want to save the file and don't know how to exit again.

I hope I explained it well enough.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=793307#c5
Comment 9 GNOME Infrastructure Team 2018-05-02 14:41:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/315.