GNOME Bugzilla – Bug 580081
[patch] Rhythmbox metadata error messages are incorrect and too vague
Last modified: 2018-05-24 14:18:26 UTC
When there is a timeout or other failure in the metadata worker process, Rhythmbox displays the error message "Internal GStreamer problem; file a bug". As seen in Bug 577433, the cause of these error messages is often a timeout when a metadata operation takes longer than expected. Thus, the error message is incorrect in pointing to GStreamer all the time. The error message is also too vague, since it does not specify which URI caused the problem. This is particularly unhelpful when many metadata operations are underway. Other information:
Created attachment 133243 [details] [review] A small patch. The patch rephrases the error message to avoid naming GStreamer. It also prints out the URI that was operated on. Note that there is no check for null pointers; those who know more about the code can probably figure out whether it's possible to end up in this function without md->priv->url being valid.
You don't need to rename your bugs to indicate there is a patch attached. This isn't how the URI should be specified. In the case of import errors (probably the vast majority of cases where this will happen), the URI is already displayed.
Well the only time I've seen that error, I haven't had a clue which URI it referred to, hence the need to display it. I hope somebody knows how to specify the URI, you can use this patch as the groundwork.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/731.