After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579965 - adding an exception for a recurring meeting does not update LAST-MODIFIED, change is not synchronized with SyncEvolution
adding an exception for a recurring meeting does not update LAST-MODIFIED, ch...
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
2.24.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-04-23 13:47 UTC by Patrick Ohly
Modified: 2009-08-07 08:15 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Proposed patch to fix this issue (1.28 KB, patch)
2009-07-31 14:51 UTC, Chen Congwu
none Details | Review
Proposed patch to fix this issue (1.28 KB, patch)
2009-07-31 14:57 UTC, Chen Congwu
none Details | Review
Proposed patch to fix this issue (1.28 KB, patch)
2009-07-31 14:57 UTC, Chen Congwu
committed Details | Review

Description Patrick Ohly 2009-04-23 13:47:22 UTC
Please describe the problem:
Whenever an event is modified, its LAST-MODIFIED property should be set anew.
SyncEvolution relies on this to find modified calendar items.

When using "Remove this Occurrence", an EXDATE is added to the VEVENT,
but it's LAST-MODIFIED is not updated. As a result this change is not
synchronized by SyncEvolution.


Steps to reproduce:
1. create a recurring event
2. save the event as iCalendar 2.0
3. use "Remove this Occurrence" in the Evolution calendar view
4. save again
5. compare LAST-MODIFIED



Actual results:
The LAST-MODIFIED is the same although the VEVENT is different.

Expected results:
The LAST-MODIFIED of the modified event should be higher.

Does this happen every time?
Yes.

Other information:
I have not verified whether this is a bug in the EDS backend or the GUI.
My understanding is that the backend normally updates the LAST-MODIFIED,
so I'm filing the bug here.
Comment 1 Chen Congwu 2009-07-31 14:51:53 UTC
Created attachment 139629 [details] [review]
Proposed patch to fix this issue

I think I have found the reason and proposed this patch.

The change is simple, just add update last-modified logic to calendar/file
backend. I have tested, it works for me.
Comment 2 Chen Congwu 2009-07-31 14:57:47 UTC
Created attachment 139631 [details] [review]
Proposed patch to fix this issue

I think I have found the reason and proposed this patch.

The change is simple, just add update last-modified logic to calendar/file
backend. I have tested, it works for me.
Comment 3 Chen Congwu 2009-07-31 14:57:47 UTC
Created attachment 139630 [details] [review]
Proposed patch to fix this issue

I think I have found the reason and proposed this patch.

The change is simple, just add update last-modified logic to calendar/file
backend. I have tested, it works for me.
Comment 4 Chen Congwu 2009-07-31 15:15:32 UTC
Sorry, network access for the web site seems extremely slow. Please ignore the triple patches, they are the same.

(In reply to comment #3)
> Created an attachment (id=139630) [edit]
> Proposed patch to fix this issue
> 
> I think I have found the reason and proposed this patch.
> 
> The change is simple, just add update last-modified logic to calendar/file
> backend. I have tested, it works for me.
> 

Comment 5 Chenthill P 2009-08-03 12:28:04 UTC
Please commit the patch.
Comment 6 Patrick Ohly 2009-08-03 12:57:17 UTC
(In reply to comment #5)
> Please commit the patch.

Congwu doesn't have commit rights and I have never tried to commit into the new git repo.

Can you commit it yourself? If not, how do I commit? Push into master?
Comment 7 Patrick Ohly 2009-08-07 08:06:54 UTC
I committed the patch into master. It's not in 2.27.5, which was tagged earlier.