After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579681 - Support ctrl+= for zoom in, and keypad for zoom in/out
Support ctrl+= for zoom in, and keypad for zoom in/out
Status: RESOLVED OBSOLETE
Product: gnome-terminal
Classification: Core
Component: Keybindings
git master
Other All
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
: 143579 647319 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-04-21 03:04 UTC by Robert Ancell
Modified: 2020-11-20 19:52 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
add accel only actions (2.43 KB, patch)
2009-08-09 16:49 UTC, Jani Monoses
rejected Details | Review

Description Robert Ancell 2009-04-21 03:04:57 UTC
Reported in Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/354447

"In gnome-terminal the 'View --> Zoom In' menu item lists the key binding of "Ctrl++" in the same way as Mozilla Firefox does.

However, on for example a pc105 keyboard (en_GB variant), you technically need to either use 'Shift+Ctrl+=' or 'Ctrl+KPLUS' (the numpad +) to cause it to zoom in. So the referenced keybinding can be slightly confusing to the novice user.

Mozilla Firefox resolves this by also binding 'Ctrl+=' to the same function so users can easily discover the feature without much thought. As such, most users have a learned response of holding Ctrl and hitting the - and = keys to zoom in and out. Gnome Terminal should probably do the same to make it easier to discover the feature."
Comment 1 Christian Persch 2009-04-21 11:00:51 UTC
This can be done by adding an accelerator-only action.
Comment 2 Jani Monoses 2009-08-09 16:49:41 UTC
Created attachment 140272 [details] [review]
add accel only actions

Adds accelerators that implement Ctrl = and Ctrl Keypad+ for zoom in, and Ctrl Keypad- for zoom out. The latter two are requested in bug 143579
Comment 3 Christian Persch 2009-08-10 12:19:39 UTC
I don't think this is the right solution, since in the keybindings editor, the user could use other accels for ZoomIn/Out where the extra accels this patch adds don't make sense.
Comment 4 Jani Monoses 2009-08-14 10:52:57 UTC
I forgot about zoom keybindings being configurable. In this case not only the extra accels (keypad + and -) would be wrong but <Ctrl>equal too should be conditional on Ctrl+ being the zoom in key.

Is there simple way of aliasing certain accelerators for others? In this case telling ctrl= to behave always like ctrl+ .
Comment 5 Christian Persch 2009-08-17 12:35:34 UTC
*** Bug 143579 has been marked as a duplicate of this bug. ***
Comment 6 Daniel O 2010-01-17 22:14:33 UTC
See also Bug 607205 (wider scope / general usability of zoom)
 * suggests changing the wording in the menu
 * suggests implementing a mousewheel zoom
 * suggests implementing a 'reset zoom level' ala firefox (CTRL 0)
Comment 7 Christopher Aillon 2011-04-21 22:59:43 UTC
*** Bug 647319 has been marked as a duplicate of this bug. ***
Comment 8 van.de.bugger 2016-08-10 20:12:20 UTC
This problem appears in other Gnome programs which have zoom in/zoom out operations: gnome-character-map, gnome-maps, and gnome-help.

I would say having non-symmetric shortcuts for zoom in/zoom out (Ctrl+SHIFT+= and Ctrl+-) is VERY inconvenient.
Comment 9 van.de.bugger 2016-08-10 20:46:13 UTC
I also found that SOME Gnome programs accepts both Ctrl+= and Ctrl+SHIFT+= for zoom in: evince, evolution, eog, shotwell, epiphany (aka Web). 

I believe this should be Gnome-wide standard shortcut, which should work in ALL applications where zoom in/zoom out operations are applicable. In sake of usability, zoom in shortcut should NOT require SHIFT, e. g. it must be Ctrl+= (Ctrl+Shift+= can be an alias).

BTW, another useful shortcut which also should be Gnome-wide is Ctrl+0 to reset zoom factor to its default value.

Thus, it is not a problem of gnome-terminal, but a problem of overall Gnome usability and should be raised appropriately.
Comment 10 Debarshi Ray 2020-11-19 18:35:36 UTC
I attached a patch to https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/313 for the alphanumeric versus numeric keypad part.
Comment 11 Debarshi Ray 2020-11-20 19:52:28 UTC
I have also attached a second patch to support Ctrl+= for zooming in:
https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/313

Let's close this in favour of the GitLab issue.