GNOME Bugzilla – Bug 579463
[cddabasesrc] [cdparanoiasrc] no longer emits discid
Last modified: 2009-04-19 17:21:03 UTC
This seems to be a regression in gstreamer/gst-plugins-base 0.10.22. The cdparanoiasrc element used to emit the cddb and musicbrainz discid, as well as the track count/number and disc duration. Output using 0.10.21: >> gst-launch-0.10 -t cdparanoiasrc device=/dev/hdc num-buffers=1 ! fakesink Setting pipeline to PAUSED ... Pipeline is PREROLLING ... FOUND TAG : found by element "cdparanoiasrc0". discid: 08121b12 discid full: 08121b12 18 150 23075 32225 46772 64795 88690 102745 115265 130742 165352 184765 200785 218025 235855 253247 273287 295997 323160 4635 musicbrainz-discid: TFZ3c5VITFkKAhz.0YQyKc.Zcwg- musicbrainz-discid-full: 01 12 00054EC2 00000096 00005A23 00007DE1 0000B6B4 0000FD1B 00015A72 00019159 0001C241 0001FEB6 000285E8 0002D1BD 00031051 000353A9 0003994F 0003DD3F 00042B87 0004843D 0004EE58 track count: 18 track number: 1 duration: 305666666666 Pipeline is PREROLLED ... Setting pipeline to PLAYING ... New clock: GstSystemClock Got EOS from element "pipeline0". Execution ended after 264559 ns. Setting pipeline to PAUSED ... Setting pipeline to READY ... Setting pipeline to NULL ... FREEING pipeline ... Output using 0.10.22: >> gst-launch-0.10 -t cdparanoiasrc device=/dev/hdc num-buffers=1 ! fakesink Setting pipeline to PAUSED ... Pipeline is PREROLLING ... FOUND TAG : found by element "cdparanoiasrc0". track count: 18 track number: 1 duration: 305666666666 Pipeline is PREROLLED ... Setting pipeline to PLAYING ... New clock: GstSystemClock Got EOS from element "pipeline0". Execution ended after 305602 ns. Setting pipeline to PAUSED ... Setting pipeline to READY ... Setting pipeline to NULL ... FREEING pipeline ...
You are right, I can reproduce this.
Created attachment 132904 [details] [review] patch fixing cddabasersc tags and unit test It's a bug in cddabasesrc, which only manifested itself once one of the MERGE_REPLACE_ALL stuff in core had been fixed, by one of these two commits: http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=f28a2a6cfc7e69279c5bda8bbdcf31039d99487f (doesn't even mention the REPLACE change in the commit message, yay) http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=c3286501b4123ba0886558ebc4900c2eb49d8357
Marking as blocker, since patch is trivial enough and it's a regression.
commit 8efe6108c4f18e8838958b40ab2323e2b26a8c9e Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Sun Apr 19 18:15:28 2009 +0100 cddabasesrc: fix posting of discid tags after MERGE_MODE_REPLACE_ALL changes in core Don't use REPLACE_ALL merge mode when that's not really what we want, as now that REPLACE_ALL actually does what it's supposed to do in core, we drop tags we wanted to keep, such as the various disc id tags. Add unit test for this as well. Fixes #579463.