After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579172 - Specified Navigation Relationships don't work
Specified Navigation Relationships don't work
Status: RESOLVED FIXED
Product: glom
Classification: Other
Component: design
git master
Other All
: Normal normal
: ---
Assigned To: Murray Cumming
Murray Cumming
Depends on:
Blocks:
 
 
Reported: 2009-04-16 15:00 UTC by Michael Hasselmann
Modified: 2009-04-23 17:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A screenshot of the mentioned layout dialog (28.89 KB, image/png)
2009-04-16 15:02 UTC, Michael Hasselmann
  Details
glom_relnav.patch (2.24 KB, patch)
2009-04-17 07:33 UTC, Murray Cumming
accepted-commit_now Details | Review

Description Michael Hasselmann 2009-04-16 15:00:53 UTC
Please describe the problem:
When layouting a Related Record Portal only the Automatic Navigation option seems to work. That is, when a user clicks for details (on a Related Record Portal) it will always take the user to the Main Relationship defined a top of the layout dialog.

Steps to reproduce:
Use the Music Example and go to the Artist table (default). The details view contains a Related Record Portal for the Artist's Albums. In developer mode right click it and select layout from the context menu. Choose a Specific Navigation Relationship other than the Main Relationship. Close the dialog and click on a row to see details. It will always open the Album table.

Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Michael Hasselmann 2009-04-16 15:02:11 UTC
Created attachment 132765 [details]
A screenshot of the mentioned layout dialog
Comment 2 Murray Cumming 2009-04-16 16:20:32 UTC
What song should it go to if you click on an album? There's no single unique record to go to. There might be a bug but this is not a sensible test case.
Comment 3 Murray Cumming 2009-04-17 07:33:23 UTC
Created attachment 132807 [details] [review]
glom_relnav.patch

This seems to fix it. It's quite simple.

I'll apply this later when I have time to figure out the git migration. Feel free to get someone to commit it in the meantime.
Comment 4 Michael Hasselmann 2009-04-17 10:08:33 UTC
Now that I worked a bit with your patch it seems to be more intuitive for the user if the list view (instead of the details view) were presented once a navrel was specified. Currently the details view seemingly picks the first entry from the table the navrel points to. My feeling is that the navrel functionality was meant to cut down the amount of indirections until a user gets to the really interesting details.

So, either think of good use cases ( = Glom example) where a Specified Navigation Relationship makes sense, or - if that is too hard - show the list view.
Comment 5 Murray Cumming 2009-04-17 13:59:32 UTC
(In reply to comment #4)
> Now that I worked a bit with your patch it seems to be more intuitive for the
> user if the list view (instead of the details view) were presented once a
> navrel was specified.

No, you are clicking on one record so you should see one record.

If you navigate to a relationship that identifies many records then maybe we could then show the list view. But I'd prefer to just prevent that - it's too complicated for a user to understand what's happening.

> Currently the details view seemingly picks the first
> entry from the table the navrel points to. My feeling is that the navrel
> functionality was meant to cut down the amount of indirections until a user
> gets to the really interesting details.
> 
> So, either think of good use cases ( = Glom example) where a Specified
> Navigation Relationship makes sense, or - if that is too hard - show the list
> view.

It was added for a particular example. I'll try to figure out which one for you. 

Comment 6 Murray Cumming 2009-04-17 14:53:02 UTC
(In reply to comment #5)
> > So, either think of good use cases ( = Glom example) where a Specified
> > Navigation Relationship makes sense,

> It was added for a particular example. I'll try to figure out which one for
> you. 

Of course the simplest example is of the user clicking on an invoice line and then seeing product details instead of invoice line details.

More importantly, could you please confirm that this bug fixes the problem for ou.


Comment 7 Michael Hasselmann 2009-04-17 14:56:45 UTC
Oh - sorry! Yes, the patch fixes it.
Comment 8 Murray Cumming 2009-04-19 18:14:15 UTC
Committed/Pushed to git master.