GNOME Bugzilla – Bug 579148
Improves the Join New room UI by adding columns, changing the UI
Last modified: 2009-04-17 20:28:34 UTC
This branch needs review: http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/room-ui
Created attachment 132755 [details] [review] diff libempathy/empathy-chatroom.c | 201 ++++++++++++++++++++++++++++++++- libempathy/empathy-chatroom.h | 12 ++ libempathy/empathy-tp-roomlist.c | 32 +++++- libempathy/empathy-tp-roomlist.h | 2 +- src/empathy-main-window.c | 32 +++++- src/empathy-main-window.glade | 2 +- src/empathy-new-chatroom-dialog.c | 188 ++++++++++++++++++++++-------- src/empathy-new-chatroom-dialog.glade | 111 +++++------------- 8 files changed, 445 insertions(+), 135 deletions(-)
We don't have glade anymore, so the patch need updating. I didn't look at code yet.
Ah that's nice! :P All that work that will now be needed to merge those simple changes!
Created attachment 132843 [details] [review] Proposed fix in branch new-room-ui http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/new-room-ui libempathy/empathy-chatroom.c | 205 +++++++++++++++++++++++++++++++++++- libempathy/empathy-chatroom.h | 12 ++ libempathy/empathy-tp-roomlist.c | 28 +++++ src/empathy-main-window.ui | 2 +- src/empathy-new-chatroom-dialog.c | 149 +++++++++++++++++--------- src/empathy-new-chatroom-dialog.ui | 112 ++++++-------------- 6 files changed, 374 insertions(+), 134 deletions(-)
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report. Reviewed by Xavier Claessens.