After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579115 - fix alignment issues with sliders
fix alignment issues with sliders
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gnome-volume-control
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-16 04:17 UTC by Matthias Clasen
Modified: 2009-05-07 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (3.43 KB, patch)
2009-04-16 04:19 UTC, Matthias Clasen 		none Details | Review
better patch (3.42 KB, patch)
2009-04-27 18:40 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2009-04-16 04:17:30 UTC 
The Balance: label should line up with the slider. 
Similarly for the Input volume.
The size-request addition is a workaround for a GTK+ bug.
Comment 1 Matthias Clasen 2009-04-16 04:19:01 UTC 
Created attachment 132739 [details] [review]
patch
Comment 2 Matthias Clasen 2009-04-27 18:40:32 UTC 
Created attachment 133438 [details] [review]
better patch

The first patch broke the alignment of sliders on the application tab (due to big icons). This one gets all sliders right.
Comment 3 Marc-Andre Lureau 2009-05-04 19:05:55 UTC 
Matthias, can you refresh the patch?

the code seems to have evolved a bit in that direction already.

I am not sure I would get the same desired effect, for example with the gtk queue resize trick.

thanks
Comment 4 Matthias Clasen 2009-05-06 18:46:04 UTC 
Hmm, looks like it only applies after Bastiens 100% mark patch in bug 574312
So best get that in first, then I'll revisit this one. 
Oh, and the queue-resize thing was a workaround for a GTK+ bug that I've now fixed, so we should drop it.
Comment 5 Bastien Nocera 2009-05-07 15:10:23 UTC 
Committed after removing the unused alignment, the queue_resize call, and changing the tabs to spaces.

commit 9b2f061d52b81d6d63e7b313f5af729baebb83e1
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Thu May 7 16:07:59 2009 +0100

    Bug 579115 – fix alignment issues with sliders
    
    Make the horizontal sliders line up with the icons and labels
    on the same line.