After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579099 - Adapt Evolution plugin to upcoming changes
Adapt Evolution plugin to upcoming changes
Status: RESOLVED FIXED
Product: nautilus-sendto
Classification: Applications
Component: general
1.1.x
Other Linux
: Normal normal
: ---
Assigned To: nautilus-sendto-maint
nautilus-sendto-maint
evolution[attachments]
: 581622 582161 (view as bug list)
Depends on: 516933
Blocks:
 
 
Reported: 2009-04-15 23:03 UTC by Matthew Barnes
Modified: 2009-05-11 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
New Evolution Plugin (15.22 KB, patch)
2009-05-05 03:42 UTC, Matthew Barnes 		none Details | Review

Description Matthew Barnes 2009-04-15 23:03:53 UTC 
I have some pending changes to Evolution that will break the plugin here.  (See: http://mbarnes.livejournal.com/2469.html)  This is a reminder to myself to update the plugin once the changes land.
Comment 1 Matthew Barnes 2009-05-05 03:42:35 UTC 
Created attachment 133987 [details] [review]
New Evolution Plugin

The plugin now handles multiple attachments.

This requires some post-2.27.1 changes in Evolution.  Pull from master and you should be fine.
Comment 2 Bastien Nocera 2009-05-05 10:55:34 UTC 
So, this patch isn't good enough to get into nautilus-sendto. We still need to be able to support both the old Evolution, and the new one.

I was half-way through updating the configures and makefiles when i realised that the plugin could live in the evo tree itself. The only thing it would need to do is check whether nautilus-sendto is in the path before adding popup menu items.

What do you think? Otherwise, I'll finish my autotools-fu to support both.

Note to self: both plugins are missing calls to gettext to setup the translation domain.
Comment 3 Matthew Barnes 2009-05-05 11:15:43 UTC 
I'm fine with moving the new code to Evolution.  That would be easier, actually, because then I could just make it a built-in type instead of a plugin.

The old code will now only build for evolution-plugin < 2.27.1.
Comment 4 Bastien Nocera 2009-05-05 11:33:27 UTC 
Cool. I disabled the evo plugin for evolution-plugin >= 2.27.1. Feel free to CC: me when you've filed a bug for merging that feature into Evo itself.
Comment 5 Bastien Nocera 2009-05-06 20:43:12 UTC 
*** Bug 581622 has been marked as a duplicate of this bug. ***
Comment 6 Götz Waschk 2009-05-11 12:05:16 UTC 
*** Bug 582161 has been marked as a duplicate of this bug. ***