Bug 578869 – glade-3 crashed with SIGSEGV in g_closure_invoke()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 578869 - glade-3 crashed with SIGSEGV in g_closure_invoke()


Summary:	glade-3 crashed with SIGSEGV in g_closure_invoke()


Status:	RESOLVED FIXED

Product:	glade
Classification:	Applications
Component:	general
Version:	3.6.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Glade 3 Maintainers
QA Contact:	Glade 3 Maintainers

URL:
Whiteboard:

Duplicates:	579339 (view as bug list)
Depends on:
Blocks:

Reported:	2009-04-13 19:49 UTC by Pedro Villavicencio
Modified:	2009-04-18 18:59 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fixes crash (577 bytes, patch) 2009-04-16 19:04 UTC, Tristan Van Berkom	none	Details \| Review

Description Pedro Villavicencio 2009-04-13 19:49:37 UTC

this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/glade-3/+bug/358467

"To reproduce, just:
- open glade-3
- create a Dialog Box
- add a button
- click the "..." near "Related action"
- click "new""

".

+ Trace 214433

Thread 1 (process 11554)

#0 related_action_pre_commit
at glade-activatable-editor.c line 329
#1 IA__g_closure_invoke
at /build/buildd/glib2.0-2.20.0/gobject/gclosure.c line 767
#2 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 3244
#3 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 2977
#4 IA__g_signal_emit
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 3034
#5 glade_eprop_object_show_dialog
at glade-editor-property.c line 2916
#6 IA__g_closure_invoke
at /build/buildd/glib2.0-2.20.0/gobject/gclosure.c line 767
#7 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 3244
#8 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 2977
#9 IA__g_signal_emit
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 3034
#10 ??
from /usr/lib/libgtk-x11-2.0.so.0
#11 IA__g_closure_invoke
at /build/buildd/glib2.0-2.20.0/gobject/gclosure.c line 767
#12 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 3174
#13 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 2977
#14 IA__g_signal_emit
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 3034
#15 ??
from /usr/lib/libgtk-x11-2.0.so.0
#16 ??
from /usr/lib/libgtk-x11-2.0.so.0
#17 IA__g_closure_invoke
at /build/buildd/glib2.0-2.20.0/gobject/gclosure.c line 767
#18 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 3282
#19 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 2987
#20 IA__g_signal_emit
at /build/buildd/glib2.0-2.20.0/gobject/gsignal.c line 3034
#21 ??
from /usr/lib/libgtk-x11-2.0.so.0
#22 gtk_propagate_event
from /usr/lib/libgtk-x11-2.0.so.0
#23 gtk_main_do_event
from /usr/lib/libgtk-x11-2.0.so.0
#24 ??
from /usr/lib/libgdk-x11-2.0.so.0
#25 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.20.0/glib/gmain.c line 1814
#26 g_main_context_iterate
at /build/buildd/glib2.0-2.20.0/glib/gmain.c line 2448
#27 IA__g_main_loop_run
at /build/buildd/glib2.0-2.20.0/glib/gmain.c line 2656
#28 gtk_main
from /usr/lib/libgtk-x11-2.0.so.0
#29 main
at main.c line 186

Comment 1 Tristan Van Berkom 2009-04-16 19:04:38 UTC

Created attachment 132778 [details] [review]
Fixes crash

The "new" item causes an object to be created and thus messes up
selection, this patch fixes selection and the code that relies
on the selected widget to not crash.

... Attaching a patch while I wait/assure Glade is migrated to Git first...

Comment 2 Ritesh Khadgaray ( irc:ritz) 2009-04-17 20:20:10 UTC

*** Bug 579339 has been marked as a duplicate of this bug. ***

Comment 3 Ritesh Khadgaray ( irc:ritz) 2009-04-17 20:25:33 UTC

glade3 crashes, when selecting a existing action from "Choose a Action in this project". 


Program terminated with signal 11, Segmentation fault.

+ Trace 214560

#0 glade_eprop_object_show_dialog
at glade-editor-property.c line 2857
#0 glade_eprop_object_show_dialog
at glade-editor-property.c line 2857
#1 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#2 IA__g_closure_invoke
at gclosure.c line 767
#3 signal_emit_unlocked_R
at gsignal.c line 3247
#4 IA__g_signal_emit_valist
at gsignal.c line 2980
#5 IA__g_signal_emit
at gsignal.c line 3037
#6 IA__gtk_button_clicked
at gtkbutton.c line 1106
#7 gtk_real_button_released
at gtkbutton.c line 1702
#8 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#9 g_type_class_meta_marshal
at gclosure.c line 878
#10 IA__g_closure_invoke
at gclosure.c line 767
#11 signal_emit_unlocked_R
at gsignal.c line 3177
#12 IA__g_signal_emit_valist
at gsignal.c line 2980
#13 IA__g_signal_emit
at gsignal.c line 3037
#14 IA__gtk_button_released
at gtkbutton.c line 1098
#15 gtk_button_button_release
at gtkbutton.c line 1594
#16 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 84
#17 g_type_class_meta_marshal
at gclosure.c line 878
#18 IA__g_closure_invoke
at gclosure.c line 767
#19 signal_emit_unlocked_R
at gsignal.c line 3285
#20 IA__g_signal_emit_valist
at gsignal.c line 2990
#21 IA__g_signal_emit
at gsignal.c line 3037
#22 gtk_widget_event_internal
at gtkwidget.c line 4761
#23 IA__gtk_propagate_event
at gtkmain.c line 2396
#24 IA__gtk_main_do_event
at gtkmain.c line 1601
#25 gdk_event_dispatch
at gdkevents-x11.c line 2364
#26 g_main_dispatch
at gmain.c line 1814
#27 IA__g_main_context_dispatch
at gmain.c line 2367
#28 g_main_context_iterate
at gmain.c line 2448
#29 IA__g_main_loop_run
at gmain.c line 2656
#30 IA__gtk_main
at gtkmain.c line 1205
#31 main
at main.c line 186

Comment 4 Ritesh Khadgaray ( irc:ritz) 2009-04-17 20:47:22 UTC

the attached patch with minor mod helps :), I have not seen anymore crashes.

--- a/gladeui/glade-editor-property.c
+++ b/gladeui/glade-editor-property.c
@@ -2854,6 +2854,8 @@ glade_eprop_object_show_dialog (GtkWidget           *dialog_button,
 
                if (selected)
                {
+                       glade_project_selection_set (project, eprop->property->widget->object, TRUE);
+
                        GValue *value = glade_property_class_make_gvalue_from_string
                                (eprop->klass, selected->name, project, eprop->property->widget);

Comment 5 Tristan Van Berkom 2009-04-18 18:59:09 UTC

Ok, I'm committing that, and some more selection paranoia from
glade-activatable-editor.c... in git master, closing this.