After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578825 - Crash during search due to treating GiggleAuthor* pointer as string
Crash during search due to treating GiggleAuthor* pointer as string
Status: RESOLVED DUPLICATE of bug 572155
Product: giggle
Classification: Other
Component: UI: History View
HEAD
Other All
: Normal critical
: ---
Assigned To: Mathias Hasselmann (IRC: tbf)
Depends on:
Blocks:
 
 
Reported: 2009-04-13 11:22 UTC by Hans Breuer
Modified: 2010-02-26 04:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
stop crashing by comparing strings with strings (2.00 KB, patch)
2009-04-13 11:25 UTC, Hans Breuer 		none Details | Review
better version by intializing value on stack (2.01 KB, patch)
2009-04-13 11:53 UTC, Hans Breuer 		none Details | Review

Description Hans Breuer 2009-04-13 11:22:33 UTC 
Patch following.
Comment 1 Hans Breuer 2009-04-13 11:25:59 UTC 
Created attachment 132589 [details] [review]
stop crashing by comparing strings with strings

Also the patch adds searching in "short-log" and moves the full log search to full_search, i.e. default search only looks into chached data, full_search is much slower due to it's git interaction.
Comment 2 Hans Breuer 2009-04-13 11:53:11 UTC 
Created attachment 132590 [details] [review]
better version by intializing value on stack

avoids:

(giggle:11219): GLib-GObject-WARNING **: gvalue.c:185: cannot initialize GValue with type `GiggleAuthor', the value has already been initialized as `(null)'
Comment 3 Javier Jardón (IRC: jjardon) 2010-02-26 04:07:12 UTC 

*** This bug has been marked as a duplicate of bug 572155 ***
Comment 4 Javier Jardón (IRC: jjardon) 2010-02-26 04:09:54 UTC 
Sorry Hans, I didn't see that you already fixed this bug here.
I already commit a patch for this issue, you can take a look to the commit in the other bug.

Please, comment if you think your solution is better. Thank you