After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578574 - always show drive names
always show drive names
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: computer backend
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2009-04-10 03:24 UTC by David Zeuthen (not reading bugmail)
Modified: 2009-12-30 00:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
What computer:/// looks like now (65.42 KB, image/png)
2009-04-10 03:25 UTC, David Zeuthen (not reading bugmail)
  Details
What computer:/// could look like (65.74 KB, image/png)
2009-04-10 03:26 UTC, David Zeuthen (not reading bugmail)
  Details
Proposed patch (2.05 KB, patch)
2009-04-10 03:27 UTC, David Zeuthen (not reading bugmail)
none Details | Review
in 2.28 with drive size on all the partitions (38.56 KB, image/png)
2009-12-30 00:12 UTC, pt3
  Details
in 2.26 with just the label (110.87 KB, image/png)
2009-12-30 00:12 UTC, pt3
  Details

Description David Zeuthen (not reading bugmail) 2009-04-10 03:24:37 UTC
There's not a lot I miss from the gnome-vfs days but one thing I do miss is the fact that computer:/// always showed the drive name even when media was inserted. One useful thing about this is that it didn't mess up the sort order. It would be good to bring that back.
Comment 1 David Zeuthen (not reading bugmail) 2009-04-10 03:25:19 UTC
Created attachment 132442 [details]
What computer:/// looks like now
Comment 2 David Zeuthen (not reading bugmail) 2009-04-10 03:26:04 UTC
Created attachment 132443 [details]
What computer:/// could look like
Comment 3 David Zeuthen (not reading bugmail) 2009-04-10 03:27:14 UTC
Created attachment 132444 [details] [review]
Proposed patch
Comment 4 Alexander Larsson 2009-04-16 09:51:58 UTC
Looks much nicer, yes.

2009-04-16  Alexander Larsson  <alexl@redhat.com>

	Bug 578574 – always show drive names in computer://

	* daemon/gvfsbackendcomputer.c:
	(recompute_files):
	If mount has a drive, use its name as part of the display name.
	Patch from David Zeuthen

Comment 5 pt3 2009-12-30 00:10:19 UTC
In previous versions of Nautilus (2.26, Ubuntu Jaunty) the computer:/// of Nautilus was very neat. It only showed you the name of the partition and not the size of the hard disk it is on (like in 2.28 in Karmic)

Is there anyway of removing the eyesore "500 GB Hardisk:" in front of the drives. It is rather unnecessary and takes the focus from most info the Name/Label/MountPoint of the partition.
Or it should be shown in a smaller and lighter text below the Name/Label/MountPoint.

Do I really need to see 500GB so many times, I bought the hard disk I know it is 500GB, I don't need to be reminded of it every day.

When one has given a label for a partition there is no need to mention how large the drive the partition sits on, after all it is limited by the partition size.

attached are screenshots of now (2.28 Karmic) and before (on 2.26)

Using Nautilus 2.28.1,
Comment 6 pt3 2009-12-30 00:12:13 UTC
Created attachment 150556 [details]
in 2.28 with drive size on all the partitions
Comment 7 pt3 2009-12-30 00:12:50 UTC
Created attachment 150557 [details]
in 2.26 with just the label