GNOME Bugzilla – Bug 578558
Add "Close Window" MenuItem and Ctrl+W accel
Last modified: 2018-12-27 19:14:47 UTC
Nuff said
Created attachment 132432 [details] [review] Patch
ctr-w is used to close tabs usually, the main window don't have tabs. You already have ESC to close the main window. Adding "Close" and "Quit" in the menu seems confusing. I don't know if it's a good idea, does anyone has an opinion here?
I think this has been pointed out in some general blog post on how to close windows / shortcuts in Gnome. IMHO, every application window should be closable with ctrl+w if it doesn't quit the app. That how things work on MacOS: you can close any window by pressing ctrl+w and and you can ctrl+q at any time too, quitting the application. May be this could be renamed Hide Contact List in the menu.
OK I had to argue the same thing with Gossip a few years back. Basically, we're already one better here in that we title the contact list correctly as "Contact List". But we still have this stupidly named "Chat" menu, for which the only menu item that makes sense to be under such a label is "New Conversation". Regardless, if we keep it as is, maybe it does make sense to rename Quit to "Quit Empathy" and rename Close to "Close Contact List"? I'm not sure how you overload the labels on stock items though.
Matthew: any advice about this issue?
http://library.gnome.org/devel/hig-book/stable/input-keyboard.html.en#standard-shortcuts says that Ctrl+W is usually Close The Current Document.
After lot of discussion, we agreed that it could make sense to consider the contact list as a kind of document and so having a "Close" button could make sense. But to implement it properly, we should first untight the contact-list and status-icon which are too connected atm. This is also needed to implement bug #599158 properly.
Review of attachment 132432 [details] [review]: This patch is outdated and should be redone properly once we have done the needed internal refactoring.
Hi Guillaume, I think the refactoring has been done ;) this patch should be forward-ported or marked obsolete.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/58.