GNOME Bugzilla – Bug 578467
Should not use deprecated gtk symbols
Last modified: 2009-06-13 23:13:43 UTC
File-roller uses the two newly deprecated gtk symbols:
These are deprecated in gtk 2.16 and should be replaced.
Created attachment 132398 [details] [review]
Replaces deprecated gtk symbols
The patch replaces the two deprecated symbols.
The required gtk version must be bumped to 2.16 for this. From configure.ac this looks non-trivial. Would you prefer an extra GTK_2_16_REQUIRED=2.16.0 or do you plan to drop the GTK_2_12_REQUIRED stuff at some point?
we can drop the gtk 2.12 compatibility source code.
Thomas, would you update your patch?
Also, instead of the current checks in configure, it could be done inline in the source files, for example:
#if GTK_CHECK_VERSION (2, 16, 0)
action = gtk_activatable_get_related_action (GTK_ACTIVATABLE (widget));
action = gtk_widget_get_action (GTK_WIDGET (proxy));
Created attachment 133210 [details] [review]
This patch uses #if GTK_CHECK_VERSION (2, 16, 0) as mentioned.
Created attachment 133220 [details] [review]
Bump gtk dep to 2.16
Gtk dep is bumped to 2.16 for gtk_activatable_get_related_action.
configure.ac: Simplified to drop the gtk 2.12 compatibility as per comment in the bug.
stc/gtk-utils.c: Removed checks for gtk < 2.13 due to new dep on 2.16.
Note that there is still code left with GTK_CHECK_VERSION (2, 12, 0) in copy-n-paste/eggdesktopfile.c
could this get in before 2.27.1?
patch applied, thank you.