Bug 578219 - toolbareditor: fix deprecated GTK+ symbols
toolbareditor: fix deprecated GTK+ symbols
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: other
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Libegg maintenance
Libegg maintenance
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-04-07 10:40 UTC by Felix Riemann
Modified: 2009-04-07 11:19 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix compilation with -DGDK_DISABLE_DEPRECATED (1.17 KB, patch)
2009-04-07 10:42 UTC, Felix Riemann 		reviewed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Felix Riemann 2009-04-07 10:40:07 UTC 
The toolbareditor currently uses the the gtk_widget_get_action function on three occasions. This function has been deprecated in gtk+-2.16 and should be replaced by gtk_activatable_get_related_action.
Comment 1 Felix Riemann 2009-04-07 10:42:10 UTC 
Created attachment 132255 [details] [review]
fix compilation with -DGDK_DISABLE_DEPRECATED

I didn't insert GTK_IS_ACTIVATABLE checks because the functions seem to be used with GtkToolitems only.
Comment 2 Christian Persch 2009-04-07 10:52:55 UTC 
Thanks!

Since this code is copied into modules which may or may not yet depend on gtk 2.16, please make this use #if GTK_CHECK_VERSION (2, 16, 0) (new code) #else (old code) #endif . Ok to commit with that fixed.
Comment 3 Felix Riemann 2009-04-07 11:19:55 UTC 
Good idea. :-)

Done.

2009-04-07  Felix Riemann  <>

	* libegg/toolbareditor/egg-editable-toolbar.c: (drag_begin_cb),
	(drag_end_cb), (configure_item_tooltip):
	Fix deprecated GTK+ symbols in the toolbareditor in a
	backwards compatible way. Fixes bug #578219.
Note You need to log in before you can comment on or make changes to this bug.