After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578212 - gnucash needs to be patch to build against goffice >= 0.7.5
gnucash needs to be patch to build against goffice >= 0.7.5
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Build system
unspecified
Other Linux
: Urgent normal
: ---
Assigned To: Phil Longstaff
Derek Atkins
: 602939 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-04-07 09:40 UTC by Jean Bréfort
Modified: 2018-06-29 22:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
makes gnucash compile with newer goffice versions (2.04 KB, patch)
2009-04-07 09:41 UTC, Jean Bréfort 		none Details | Review
updated patch (6.52 KB, patch)
2009-04-10 15:14 UTC, Jean Bréfort 		none Details | Review
patch against most recent svn trunk. (7.55 KB, patch)
2009-04-30 08:02 UTC, Jean Bréfort 		accepted-commit_now Details | Review

Description Jean Bréfort 2009-04-07 09:40:32 UTC 
Due to some renaming in goffice, such as GOG_GRAPH_TYPE to GOG_TYPE_GRAPH, gnucah needs a patch I'll attach shortly.
Comment 1 Jean Bréfort 2009-04-07 09:41:52 UTC 
Created attachment 132251 [details] [review]
makes gnucash compile with newer goffice versions

This should not break things with older goffice versions.
Comment 2 Jean Bréfort 2009-04-10 15:14:47 UTC 
Created attachment 132470 [details] [review]
updated patch

This new version is needed now that the planned GogStyle -> GOStyle change is there. There no more planned breakages around.
Comment 3 Vincent Untz 2009-04-27 14:54:44 UTC 
I think the patch is broken. It seems to contain some changes twice (hunks 8, 9 and 10 are the same as hunks 5, 6 and 7).
Comment 4 Jean Bréfort 2009-04-27 15:49:38 UTC 
Looks like gnucash code changed recently, so that the patch is not anymore valid.
Comment 5 Jean Bréfort 2009-04-30 08:02:05 UTC 
Created attachment 133633 [details] [review]
patch against most recent svn trunk.

Please apply this patch before changing everything once more.
Comment 6 Jean Bréfort 2009-04-30 08:05:46 UTC 
Should be fixed as soon as possible, please.
Comment 7 Jean Bréfort 2009-04-30 21:12:48 UTC 
I can't commit: no svn account. Someone else will have to do it.
Comment 8 Phil Longstaff 2009-04-30 21:19:22 UTC 
I'll do it either later this evening or tomorrow.
Comment 9 Phil Longstaff 2009-05-01 23:39:54 UTC 
Committed as r18066
Comment 10 Christian Stimming 2009-11-25 14:10:28 UTC 
*** Bug 602939 has been marked as a duplicate of this bug. ***
Comment 11 John Ralls 2018-06-29 22:20:29 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=578212. Please update any external references or bookmarks.