After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578018 - use G_DEFINE_TYPE and similar macros
use G_DEFINE_TYPE and similar macros
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.28.x
Other All
: Normal trivial
: ---
Assigned To: pango-maint
pango-maint
Depends on: 449565
Blocks:
 
 
Reported: 2009-04-05 13:47 UTC by Behdad Esfahbod
Modified: 2011-05-02 00:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use G_DEFINE_INTERFACE for PangoCairoFont and PangoCairoFontMap (3.14 KB, patch)
2010-04-20 01:26 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
pango/modules.c: Use G_DEFINE_TYPE instead custom macro (1.84 KB, patch)
2011-04-30 12:00 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review

Description Behdad Esfahbod 2009-04-05 13:47:58 UTC 
There's just a few places remaining that we register types directly.  The hardest one to change is the interface registrations in pangocairo.

Apart from that, most other places use PANGO_DEFINE_TYPE, so we should just switch that.
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-20 01:26:48 UTC 
Created attachment 159129 [details] [review]
Use G_DEFINE_INTERFACE for PangoCairoFont and PangoCairoFontMap
Comment 2 Javier Jardón (IRC: jjardon) 2011-04-26 10:52:27 UTC 
Could this get a review, please?
Comment 3 Behdad Esfahbod 2011-04-26 22:16:10 UTC 
Does this change the gobject name of the interface?  Do we care?
Comment 4 Javier Jardón (IRC: jjardon) 2011-04-27 10:48:14 UTC 
I used a typedef for that.
This is the same thing we did in glib and gtk to not change all the names in the source code
Comment 5 Behdad Esfahbod 2011-04-27 14:34:23 UTC 
Go ahead then.  Are you also doing PANGO_DEFINE_TYPE to G_DEFINE_TYPE conversion?
Comment 6 Javier Jardón (IRC: jjardon) 2011-04-30 12:00:13 UTC 
Created attachment 186931 [details] [review]
pango/modules.c: Use G_DEFINE_TYPE instead custom macro
Comment 7 Behdad Esfahbod 2011-05-02 00:57:41 UTC 
Thanks Javier.