After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577900 - Blank lines in Firefox text areas incorrectly spoken
Blank lines in Firefox text areas incorrectly spoken
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.26.x
Other Linux
: Normal normal
: 2.26.3
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-04-04 03:42 UTC by Nolan Darilek
Modified: 2009-05-21 20:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
revision 1 (1.27 KB, patch)
2009-05-18 22:31 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Nolan Darilek 2009-04-04 03:42:39 UTC
In a text area, blank lines are spoken as "end of line" rather than "blank."
Comment 1 Willie Walker 2009-04-30 17:15:28 UTC
Confirming.  When I enter text in the "Additional Comments" area of a bugzilla page, Orca reads empty lines as "newline" instead of "blank" whereas the same text in gedit results in "blank" being spoken.
Comment 2 Joanmarie Diggs (IRC: joanie) 2009-05-18 22:31:50 UTC
Created attachment 134899 [details] [review]
revision 1

Pylinted; not yet regression tested, but it seems safe and solves the problem for me. I'll run the regression tests. In the meantime, Will please review. Thanks!
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-05-18 22:36:07 UTC
Also retargeting for 2.26.3 as it seems low risk. Plus in looking at this bug I found a case where right arrow was not speaking anything when it should have been announcing the blank line. (Technically a different bug, but this patch fixes that issue as well.)
Comment 4 Willie Walker 2009-05-19 00:58:57 UTC
Looks good to me.  Many thanks, Joanie!  I say commit to master and gnome-2-26.
Comment 5 Joanmarie Diggs (IRC: joanie) 2009-05-21 20:50:33 UTC
Thanks Will. I wanted to run all of the Firefox regression tests just to be sure. Took me longer than anticipated to get around to that. Sorry! Anyhoo, having done so, I've now committed this fix to master and the gnome-2-26 branch. Closing as FIXED.