After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577794 - [playbin2] leaks elements set through properties
[playbin2] leaks elements set through properties
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-03 00:14 UTC by René Stadler
Modified: 2009-04-10 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simple test program (1.36 KB, text/x-csrc)
2009-04-03 00:18 UTC, René Stadler 		  Details
Proposed patch for audio-sink, video-sink leakage (2.38 KB, patch)
2009-04-03 00:19 UTC, René Stadler 		committed Details | Review

Description René Stadler 2009-04-03 00:14:38 UTC 
When setting the video-sink, audio-sink or vis-plugin properties of playbin2, a reference to the passed element is leaked. Haven't checked yet if text-sink is affected too.

Attaching test program and proposed patch for audio-sink, video-sink leakage. vis-plugin is harder to fix, patch might come later.
Comment 1 René Stadler 2009-04-03 00:18:43 UTC 
Created attachment 131960 [details]
Simple test program

Depending on which kind of file you point it to (audio only vs. audio+video), this can trivially reproduce the leaks.
Comment 2 René Stadler 2009-04-03 00:19:44 UTC 
Created attachment 131961 [details] [review]
Proposed patch for audio-sink, video-sink leakage
Comment 3 Wim Taymans 2009-04-10 11:29:08 UTC 
A similar patch:

commit 33ef15fad6bb9047da7314b5fb6a34772e83f0f5
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Apr 10 13:27:41 2009 +0200

    playsink: fix refcounting of custom elements
    
    Sink the custom sinks, let other elements we create be sunken by the bin we add
    them to.
    Fixes #577794.
Comment 4 Wim Taymans 2009-04-10 11:43:57 UTC 
commit 1a557e60eaef102aefd97831811aec2161cbf158
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Apr 10 13:42:56 2009 +0200

    playbin2: fix refcounting of visualisations
    
    See #577794.
Comment 5 Wim Taymans 2009-04-10 11:46:24 UTC 
commit 4f89685217d33a24dd9e9c079730fbb56ca83ed8
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Apr 10 13:44:40 2009 +0200

    check: add a unit test for playbin2
    
    Add unit test for playbin2 and include the refcount test in #577794.