GNOME Bugzilla – Bug 577596
Syntax highlighting for Automake files
Last modified: 2014-04-23 21:20:58 UTC
.am need to use the makefile highlighting
Moving to gtksourceview - we use their magic to detect the correct highlighting engine.
Created attachment 157062 [details] [review] Fix makefile highlighting for .am files
Created attachment 171535 [details] [review] Patch to add Automake syntax highlighting and improve Makefile highlighting I'd like to contribute this language definition file for Automake files. It highlights makefile variables that mean something special to Automake, as well as doing regular makefile highlighting. It also improves the current makefile.lang so that it highlights the bodies of rules as shell code. This patch obsoletes the previous patch for this bug.
P.S. The patch is on gnome-2-30, not master, because I don't have GTK 3 on this box.
Created attachment 171543 [details] Zip of files changed in patch Added whole files for use in master
Created attachment 189360 [details] [review] Revised patch against master Hey, here's a patch against git master, finally!
Ping?
Can you please change the license to LGPL? Currently, that's the only license being accepted for the project (see bug #159134).
Created attachment 196656 [details] [review] LGPLv3 patch Of course. Here is another patch licensed LGPLv3.
Review of attachment 196656 [details] [review]: Hi sorry for the delay. I am checking this out from my phone so I will need to take a closer look and test when I am back home, however the patch looks good at a first glance. With regard to licensing would you be ok with lgplv2 like the rest of gtksourceview? If we include this now the file will need to go in potfiles.skip for this cycle since we are already string frozen. Did you make up the mime type or is it part of shared-mime-info? We prefer to include the mime metadata only if it is official otherwise it can be omitted
I hereby grant you permission to license it under whatever license will get the patch accepted. I made up the mime type, so feel free to delete line 27 of automake.lang.
The lang file is now on git master and will be in the next version. I also removed the Makefile.* glob from makefile.lang so that automake.lang is properly detected for Makefile.am files. Thanks again for the contribution and for you patience :-)
Thank you too for reviewing it!
Created attachment 274999 [details] [review] Use map_width and not map_size in update_clones
Created attachment 275000 [details] [review] Position user layers on the center of the viewport