Bug 577576 - Failed to read saved session file warning on new sessions.
Failed to read saved session file warning on new sessions.
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.26.x
Other All
: Normal trivial
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-04-01 04:45 UTC by Tomislav Vujec
Modified: 2010-09-29 17:32 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
Proposed patch to remove the warning. (492 bytes, patch)
2009-04-01 04:45 UTC, Tomislav Vujec
none Details | Diff | Review
Don't warn about a missing session file (1.38 KB, patch)
2009-11-18 00:45 UTC, Owen Taylor
committed Details | Diff | Review

Description Tomislav Vujec 2009-04-01 04:45:15 UTC
Please describe the problem:
When started without session related command line parameters (e.g. from gnome-session), metacity picks up client_id from the DESKTOP_AUTOSTART_ID environment variable. Unfortunately, there is no way to distinguish if this was passed from a config file, representing old saved session, or generated by gnome-session, therefore load_state is attempted in each case. If the client_id is generated, there will be no session file, and metacity will report a warning. Since use case of starting new fresh session is much more common than loading existing saved session, most users will find a warning in their session log file (e.g. .xsession-errors), which can be fairly confusing. Warning should be either removed or changed to a debug message. Alternatively, there should be a method to distinguish between generated and restored IDs, but that might require changes to the autostart specs.

Steps to reproduce:
Log into gnome desktop without any saved sessions.

Actual results:
metacity reports warning:
Window manager warning: Failed to read saved session file <HOME>/.config/metacity/sessions/<ID>.ms: Failed to open file '<HOME>/.config/metacity/se
ssions/<ID>.ms': No such file or directory

Expected results:
No warning.

Does this happen every time?
Yes

Other information:
Comment 1 Tomislav Vujec 2009-04-01 04:45:56 UTC
Created attachment 131825 [details] [review]
Proposed patch to remove the warning.
Comment 2 Owen Taylor 2009-11-18 00:45:10 UTC
Created attachment 148013 [details] [review]
Don't warn about a missing session file

Here's Tomislav's patch a git patch with a commit message; it looks good
and makes sense to me.
Comment 3 Thomas Thurman 2010-05-02 15:05:30 UTC
Review of attachment 148013 [details] [review]:

Makes sense to me as well.
Comment 4 Matthias Clasen 2010-09-29 17:32:05 UTC
This has been committed a while ago.

Note You need to log in before you can comment on or make changes to this bug.