After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577396 - Rating is not transferred to iPod
Rating is not transferred to iPod
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - iPod
git master
Other All
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-31 03:58 UTC by Andrés G. Aragoneses (IRC: knocte)
Modified: 2012-06-01 17:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (637 bytes, patch)
2009-03-31 03:59 UTC, Andrés G. Aragoneses (IRC: knocte)
committed Details | Review
Changes the Weighting of the ratings according to libgpod documentation (1.80 KB, patch)
2012-06-01 12:38 UTC, Samuel Gyger (IRC: thinkabout)
committed Details | Review

Description Andrés G. Aragoneses (IRC: knocte) 2009-03-31 03:58:46 UTC
Please describe the problem:
Rating of songs is not transferred to iPod when synchronizing.

Steps to reproduce:
1. Mark some rating to a song.
2. Connect iPod -> sync happens.
(...)
4. Eject the iPod. Play the song in the iPod.


Actual results:
After 2: The Rating is not copied into the song created for the Music library of the iPod.
After 5: The Rating is not present on the iPod when playing from there.

Expected results:
The rating to be copied.

Does this happen every time?
Yes.

Other information:
I'll provide a patch.
Comment 1 Andrés G. Aragoneses (IRC: knocte) 2009-03-31 03:59:36 UTC
Created attachment 131749 [details] [review]
Proposed patch

This fixes the problem.
Comment 2 Gabriel Burt 2009-04-02 19:10:32 UTC
Committed, thanks Andres.
Comment 3 Samuel Gyger (IRC: thinkabout) 2012-05-31 23:15:53 UTC
I think with the move to libgpod we lost the ability again to get the rating of a song on the ipod. At least on my ipod if I move a song with a rating to the ipod nothing happens on the ipod.

Please reopen the bug.
Comment 4 Samuel Gyger (IRC: thinkabout) 2012-06-01 12:38:47 UTC
Created attachment 215405 [details] [review]
Changes the Weighting of the ratings according to libgpod documentation

Changed the weighting from 1 to 20, one star is 20 "points", see http://www.gtkpod.org/libgpod/docs/libgpod-Tracks.html under rating.

This patch should fix the issue, tested with my Nano 5g.
Comment 5 Bertrand Lorentz 2012-06-01 16:47:29 UTC
Re-opening, as per above comments.
Comment 6 Bertrand Lorentz 2012-06-01 17:20:20 UTC
Comment on attachment 215405 [details] [review]
Changes the Weighting of the ratings according to libgpod documentation

Thanks for the patch!
I've committed it with a small change: creating a constant member to hold the value of ITDB_RATING_STEP in one place, and use that member in the two places it's needed.
Comment 7 Bertrand Lorentz 2012-06-01 17:20:39 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.