After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577054 - [videoscale] Not valgrind clean
[videoscale] Not valgrind clean
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-28 09:53 UTC by Sebastian Dröge (slomo)
Modified: 2009-04-02 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
log (428.63 KB, text/plain)
2009-03-28 10:14 UTC, Sebastian Dröge (slomo) 		Details
log (325.49 KB, text/plain)
2009-03-29 10:25 UTC, Sebastian Dröge (slomo) 		Details

Description Sebastian Dröge (slomo) 2009-03-28 09:53:29 UTC 
Hi,
videoscale is currently not valgrind clean... attached is the valgrind.log file from running the new unit test.
Comment 1 Sebastian Dröge (slomo) 2009-03-28 10:14:43 UTC 
Created attachment 131545 [details]
log
Comment 2 Sebastian Dröge (slomo) 2009-03-29 10:03:18 UTC 
commit ab7d52c0536d91dd0b208541da43e800f340c692
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sun Mar 29 12:01:33 2009 +0200

    videoscale: Fix linear scaling for one byte components
    
    Fixes bug #577054.

commit 954b1713e13290ef2ceacff63caec419b8722888
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sun Mar 29 11:53:40 2009 +0200

    videoscale: Fix 4tap scaling of YUYV and friends

commit 9d586e04757aaa49f5606e8b5322466decbf9ddb
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Mar 28 16:08:44 2009 +0100

    videoscale: Rewrite YUYV (and friends) scaling and don't read/write over lin
    
    Partially fixes bug #577054, there's just one issue left now.

commit 5545a9704e0c1a744f3d1a676ad6f6371d6ba869
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Mar 28 12:48:04 2009 +0100

    videoscale: Add some more unit tests

commit b5793ccd0d33b4cfa04f5ea900a047ab646f7b68
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Mar 28 11:51:01 2009 +0100

    videoscale: Use bilinear instead of 4tap scaling for heights < 4
    
    Partially fixes bug #577054.

commit 8eb3572eefc1f2cf3b0037a76b01d3b657d61505
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Mar 28 11:45:41 2009 +0100

    videoscale: Don't read after the end of a line when lineary scaling YUYV/UYV
    
    This case is for upscaling a frame with width=1
    Partially fixes bug #577054.

commit b69231ad214b28a267c3e14ce66c27e2b124ba7e
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Mar 28 11:27:56 2009 +0100

    videoscale: Don't read after the end of a line when lineary scaling YUYV/UYV
    
    Partially fixes bug #577054.
Comment 3 Sebastian Dröge (slomo) 2009-03-29 10:25:14 UTC 
Created attachment 131615 [details]
log

Actually not 100% valgrind clean yet...
Comment 4 Sebastian Dröge (slomo) 2009-04-02 09:36:50 UTC 
commit 22f99da35c329c1f6c4c7dc4f7d3516409ee502b
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Apr 2 11:10:12 2009 +0200

    videoscale: Don't read over line ends when taking the last Cr or Cb

commit db1236505e4a7ccd3a81ffb007777e7695f46f47
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Apr 2 10:52:06 2009 +0200

    videoscale: Don't write to few pixels and don't mix Cr and Cb
    
    Fixes bug #577054.