After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 57692 - g_io_channel_win32_no_seek() no longer needed
g_io_channel_win32_no_seek() no longer needed
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: win32
1.3.x
Other Linux
: Normal trivial
: ---
Assigned To: Tor Lillqvist
Tor Lillqvist
Depends on:
Blocks:
 
 
Reported: 2001-07-17 22:00 UTC by Ron Steinke
Modified: 2011-02-18 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ron Steinke 2001-07-17 22:00:49 UTC 
The function g_io_channel_win32_no_seek() should no longer be called
by the GIOChannel API functions, and can probably be removed at
some point after testing has confirmed this
Comment 1 Hans Breuer 2001-11-11 20:23:40 UTC 
AFAICS g_io_channel_seek () does only check the is_seekable flag with 
g_return_if_fail() so doesn't your suggestion mean to call a function 
via a NULL pointer ? Same for g_io_channel_seek_position ().

Or am I missing something ?
Comment 2 Ron Steinke 2001-11-11 21:24:16 UTC 
The function g_io_channel_win32_no_seek() only appears
in the GIOFuncs structures for the socket and message
channels. For these channels, is_seekable is always false,
so g_io_channel_win32_no_seek() should never be called
(if you look at the function body, it consists entirely
of g_assert(FALSE) and a dummy return value). If we're not
hitting the assert, the function is successfully not being
called, and can be removed. If you're concerned about
safety, we could stick asserts before the two calls
to io_seek() in giochannel.c.
Comment 3 Owen Taylor 2002-03-07 19:27:05 UTC 
Moving open 2.0.0 Win32 bugs to 2.0.1 milestone.
Comment 4 Owen Taylor 2002-03-25 22:24:34 UTC 
Moving 2.0.1 Win32 bugs to 2.0.2 milestone.
Comment 5 Tor Lillqvist 2002-12-17 04:55:05 UTC 
Fixed in HEAD.