After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576863 - Code reading gnome-version.xml assumed it's well-formed
Code reading gnome-version.xml assumed it's well-formed
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: sysinfo
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Robert Roth
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-26 15:44 UTC by Vincent Untz
Modified: 2011-11-15 09:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (900 bytes, patch)
2011-11-15 05:01 UTC, Robert Roth 		none Details | Review

Description Vincent Untz 2009-03-26 15:44:30 UTC 
I was playing with gnome-version.xml to try some things, and broke it for fun. It seems gnome-system-monitor doesn't really like the case where it's broken.

src/sysinfo.cpp:load_gnome_version() shouldn't set this->gnome_version if one of the three nodes that should be read couldn't be read.
Comment 1 Robert Roth 2011-11-15 05:01:20 UTC 
Created attachment 201418 [details] [review]
Proposed patch

I can confirm this with the latest HEAD from git, and I'm attaching a patch to avoid setting incomplete gnome version number, so if any of the major, minor, micro version number can not be read, the version number will not be displayed at all to avoid displaying incomplete version numbers (3.2. or 3..0 or .0.2)
Comment 2 Chris Kühl 2011-11-15 09:06:05 UTC 
Thanks. Patch committed.