After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576681 - Improve search performance
Improve search performance
Status: RESOLVED OBSOLETE
Product: gitg
Classification: Applications
Component: gitg
git master
Other All
: Normal major
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2009-03-25 09:50 UTC by jessevdk@gmail.com
Modified: 2018-05-22 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The minor improve (700 bytes, patch)
2009-07-14 08:51 UTC, Guilhèm Bonnefille
rejected Details | Review

Description jessevdk@gmail.com 2009-03-25 09:50:26 UTC
The search performance is rather poor at the moment for large repositories (it's just a linear search, the slowest thing possible).
Comment 1 Guilhèm Bonnefille 2009-04-28 18:44:36 UTC
The hash search can be improved by replacing strncmp+strlen by g_str_has_prefix.

Please, take a look at:
http://github.com/guyou/gitg/commit/2cbb5db4075591f5b55b33f6347a0edd2e701eb0
Comment 2 Guilhèm Bonnefille 2009-07-14 08:51:21 UTC
Created attachment 138381 [details] [review]
The minor improve
Comment 3 Ignacio Casal Quinteiro (nacho) 2011-07-21 13:21:18 UTC
Review of attachment 138381 [details] [review]:

Makes sense this patch. Feel free to push.
Comment 4 Guilhèm Bonnefille 2011-07-21 15:20:52 UTC
Not sure who is the recipient of this message.

Personnaly, I do not have push access (nor gtk3 compatible system).
Comment 5 Ignacio Casal Quinteiro (nacho) 2011-07-21 19:44:13 UTC
Comment on attachment 138381 [details] [review]
The minor improve

Seems that jesse already fixed this part of the code in a different way. Thanks anyway
Comment 6 Guilhèm Bonnefille 2012-04-01 19:06:01 UTC
Code is fixed. Please, close the bug.
Comment 7 Ignacio Casal Quinteiro (nacho) 2012-04-01 19:07:10 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 8 jessevdk@gmail.com 2012-07-12 11:18:03 UTC
This is really not fixed. Sure the patch is good but that's not what this bug report is about. Fast searching requires indexing the history properly so we can quickly search and filter the history etc.
Comment 9 GNOME Infrastructure Team 2018-05-22 13:00:38 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gitg/issues/1.