GNOME Bugzilla – Bug 576681
Improve search performance
Last modified: 2018-05-22 13:00:38 UTC
The search performance is rather poor at the moment for large repositories (it's just a linear search, the slowest thing possible).
The hash search can be improved by replacing strncmp+strlen by g_str_has_prefix. Please, take a look at: http://github.com/guyou/gitg/commit/2cbb5db4075591f5b55b33f6347a0edd2e701eb0
Created attachment 138381 [details] [review] The minor improve
Review of attachment 138381 [details] [review]: Makes sense this patch. Feel free to push.
Not sure who is the recipient of this message. Personnaly, I do not have push access (nor gtk3 compatible system).
Comment on attachment 138381 [details] [review] The minor improve Seems that jesse already fixed this part of the code in a different way. Thanks anyway
Code is fixed. Please, close the bug.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
This is really not fixed. Sure the patch is good but that's not what this bug report is about. Fast searching requires indexing the history properly so we can quickly search and filter the history etc.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gitg/issues/1.