GNOME Bugzilla – Bug 576477
links to devhelp documentation don't work
Last modified: 2010-01-28 04:13:05 UTC
this report has been filed here: https://bugs.edge.launchpad.net/glade-3/+bug/347520 "the Shortcut to the devhelper documentation don't work For example, when you rigth-click in a widget and click on read documentation, glade points you to page:GtkDialog, but it don't show anything. if a write manually GtkDialog, the manual page shows" Is this a glade-3 or a devhelp issue? Thanks in advance,
I'll test this when I boot up from the linux box but there may be some issues I already know about... as far as I know basic page references should still work, but; in this release of GTK+ there has been a few new interfaces added, which take ownership of properties instead of the implementing widgets who originally documented them, so - this breaks DevHelp lookups on alot of properties - for this I am gambling that 3.6 is released on peoples computers along with updated GTK+ documentation (the breakage I know of only exists with skewed documentation version/Glade version).
I have the same behavior with glade 3.6 and devhelp 0.22. All doc packages are from ubuntu 8.10 repositories.
Confirmed in final jaunty release: glade 3.6.1 and devhelp 0.22
Created attachment 151802 [details] [review] Fix shortcuts to devhelper documentation Here the trivial patch commit 810c5b3c335cd09d750b933720ae4d222aaa44eb Author: Javier Jardón <jjardon@gnome.org> Date: Wed Jan 20 03:01:34 2010 +0100 Fix shortcuts to devhelper documentation Remove the trailing whitespace of the string passed to devhelp Fixes https://bugzilla.gnome.org/show_bug.cgi?id=576477 diff --git a/gladeui/glade-utils.c b/gladeui/glade-utils.c index 276c656..d17f330 100644 --- a/gladeui/glade-utils.c +++ b/gladeui/glade-utils.c @@ -1661,7 +1661,7 @@ glade_util_search_devhelp (const gchar *book, g_return_if_fail (glade_util_have_devhelp ()); if (book) book_comm = g_strdup_printf ("book:%s ", book); - if (page) page_comm = g_strdup_printf ("page:%s ", page); + if (page) page_comm = g_strdup_printf ("page:%s", page); string = g_strdup_printf ("devhelp -s \"%s%s%s\"", book_comm ? book_comm : "",
a) does that really fix the problem for page sensitive searching ? (and show the top of page for a said widget class ?) b) do the property searches still work ? My guess is that the property searches will break if the trailing space after the "book:%s" is missing before the search string.
Created attachment 151829 [details] [review] Fix shortcuts to devhelper documentation.v2 > b) do the property searches still work ? Oops, here a new patch to fix this
Review of attachment 151829 [details] [review]: Looks fine, please commit, sorry I havent taken time to compile and test it but it looks like a harmless patch anyway.
Comment on attachment 151829 [details] [review] Fix shortcuts to devhelper documentation.v2 commit 22788e3f90e2285fd9db92e60cbadac5cc6d62ee
This problem has been fixed in the development version. The fix will be available in the next major software release. Thanks Tristan for the review!