After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576187 - [playbin2] Stalls video sink when disabling subtitles in PLAYING state
[playbin2] Stalls video sink when disabling subtitles in PLAYING state
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: 0.10.23
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks: 542663
 
 
Reported: 2009-03-21 13:43 UTC by Sebastian Dröge (slomo)
Modified: 2009-03-24 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2009-03-21 13:43:53 UTC
Hi,
when disabling the subtitles via the flags property while in PLAYING state the video stops playing and audio continues for some time.
Comment 1 Sebastian Dröge (slomo) 2009-03-22 14:57:31 UTC
And a similar issue: If switching to another file after playing something with subtitles it deadlocks most of the time. Can also easily be reproduced with the playbin2 patch for totem...
Comment 2 Wim Taymans 2009-03-23 14:28:48 UTC
commit 7cc84f9205211d1a7b0b1011745981415cf50109
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Mar 23 15:27:27 2009 +0100

    playbin2: fix linking order
    
    Link after doing the state change and unlink before shutting down. Makes the
    window for causing races in toggling the visualisations smaller.
    See #576187.
Comment 3 Wim Taymans 2009-03-23 15:07:38 UTC
commit d8003bea0637c59ac82aab7364f04a394299dd5b
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Mar 23 16:04:27 2009 +0100

    playbin2: fix dynamic switching of visualisations
    
    Fix the switching of visualisations by requesting and releasing the tee request
    pads on demand.
    See #576187.
Comment 4 Sebastian Dröge (slomo) 2009-03-23 15:18:43 UTC
Are you sure you didn't mean bug #576188 or bug #576403?
Comment 5 Wim Taymans 2009-03-23 16:40:39 UTC
commit 7628319688e0fc931d177114c477629bc8ff913c
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Mar 23 17:37:48 2009 +0100

    playbin2: allow dynamic swtiching of subtitles
    
    When we have the textpad configured, enable and disable the subtitles by setting
    the silent flag on the overlay element instead of trying to remove elements.
    See #576187

Comment 6 Wim Taymans 2009-03-23 17:17:45 UTC
Now I don't get the bug in Comment #1 anymore. Can you confirm and close this bug?
Comment 7 Sebastian Dröge (slomo) 2009-03-24 11:41:49 UTC
Yeah, works fine now... thanks :)