GNOME Bugzilla – Bug 576006
RANDR confirmation dialog appears under the gnome-display-properties window
Last modified: 2009-03-19 23:51:58 UTC
The confirmation dialog from the RANDR plugin appears under the gnome-display-properties window, as it does not set that window as its transient parent. The following two patches do this: 1. Add a new DBus interface, "XRANDR_2", to the RANDR plug-in. This has an ApplyConfiguration method that takes a parent window and a timestamp as arguments. 2. Make gnome-display-properties look for that interface and use it; if it doesn't exist, the old interface is used as usual. This bug started as https://bugzilla.novell.com/show_bug.cgi?id=486019
Created attachment 131002 [details] [review] gnome-settings-daemon-bgo576006-randr-confirmation-dialog-transient.diff
Created attachment 131003 [details] [review] gnome-control-center-bnc576006-randr-confirmation-dialog-transient.diff
Committed to gnome-settings-daemon: 2009-03-19 Federico Mena Quintero <federico@novell.com> http://bugzilla.gnome.org/show_bug.cgi?id=576006 - The confirmation dialog from the RANDR plugin can appear behind the window from gnome-display-properties. This also depends on a change to gnome-control-center. * plugins/xrandr/gsd-xrandr-manager.xml: Add an org.gnome.SettingsDaemon.XRANDR_2 interface in addition to the old XRANDR one, with an ApplyConfiguration method that also takes a parent window ID and a timestamp. * plugins/xrandr/gsd-xrandr-manager.c (gsd_xrandr_manager_2_apply_configuration): Implement the new DBus method with the parent window and timestamp. (user_says_things_are_ok): Use the parent window. Committed to gnome-control-center: 2009-03-19 Federico Mena Quintero <federico@novell.com> http://bugzilla.gnome.org/show_bug.cgi?id=576006 - The confirmation dialog from the RANDR plugin can appear behind the window from gnome-display-properties. This also depends on a change to gnome-settings-daemon, although it will work with older g-s-d as well. * xrandr-capplet.c (apply): Call the new DBus API for ApplyConfiguration in org.gnome.SettingsDaemon.XRANDR_2, or the old one if that fails. (begin_version2_apply_configuration): New helper function; calls the new API. (begin_version1_apply_configuration): New helper function; calls the old API. (apply_configuration_returned_cb): If the new API is not available, try the old one. This makes us compatible with older versions of gnome-settings-daemon. (error_message): Allow a NULL secondary_text.