GNOME Bugzilla – Bug 575842
MP4 tags are read incorrectly
Last modified: 2010-09-09 00:03:10 UTC
For some mp4 video files tags are completely absent. When reading tags on mp4 file, TagLib.Mpeg4.FileParser takes in account only first 'udta' entry, while tags actually may appear in subsequent 'udta' entires.
Created attachment 163112 [details] [review] Patch to fix mpeg4 file parsing of udta boxes.
I've run into the same problem. See the previous entry for the patch. The patch maintains a collection of udta boxes instead of just a single entry.
Review of attachment 163112 [details] [review]: Thanks for the patch, Colin. It looks good at a quick glance - no public API changes, good formatting. Could you include one or more unit test that fails without your patch and passes with it?
Hi Gabriel, I'm attaching 2 files. The first is the patch to add the new unit test. The 2nd is a zipped version of the sample.m4v file which should be placed in the samples directory. The ReadTags unit test will fail with an older version of the library. Thanks!
Created attachment 163232 [details] [review] Patch to add new unit test class
Created attachment 163233 [details] sample.m4v file to add to samples directory
Created attachment 163236 [details] [review] Please use this unit test patch - original had a minor bug Oops, the original unit test patch had an incorrect date. Please use this one instead.
Thanks Colin, both patches look fine except: * There were many tabs/spaces and formatting inconsistencies * The line endings in tests.csproj have been changed * You forgot to add an entry to tests/Makefile.am I committed corrected files to my github clone of taglib-sharp [1] and sent a pull request [2] to the main repository. I will close this bug when the request is merged. [1] http://github.com/alexkay/taglib-sharp [2] http://github.com/mono/taglib-sharp/pull/1
Alexander, Thanks. I'll double check my editor settings next time.
Pushed the commit, closing.