GNOME Bugzilla – Bug 575709
Request a key frame
Last modified: 2010-05-10 10:45:31 UTC
Please describe the problem: There are some cases when you need to request a key frame from the encoder (Video Fast Update, for example) this is not currently possible with gst-ffmpeg. The only encoder which supports it is theora encoder in gst-plugins-base. It would be nice to have this in ffmpeg as well. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 130833 [details] [review] Adds support for this feature
Looks good to me. Unless wtay has some other input on this it can be committed after the freeze.
looks good to me.
commit a44f5b4df3c7c806820358d0c4913cc53c44da46 Author: Janin Kolenc <janin dot kolenc at marand dot si> Date: Wed Mar 25 12:51:55 2009 +0100 ffenc: Add support for I-frame request. Add request for I-frame request using GstForceKeyUnit event. Fixes #575709.
Created attachment 132654 [details] [review] ffenc: Make upstream forcekeyunit event handling thread safe The current code can modify the struct passed to ffmpeg in the srcpad event handler, since its not under the stream lock. Attach patch should fix that.
Above patch is included in: commit b69fcc471ea268587a8796ddffc888f321933d0a Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Fri Nov 20 21:46:33 2009 -0500 ffenc: Make keyframe forcing thread-safe Make the keyframe forcing thread-safe, also emit a downstream event to allow muxers or payloaders to react appropriately. https://bugzilla.gnome.org/show_bug.cgi?id=602556