After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575684 - Desktop launcher properties window disappears when $HOME is on NFS
Desktop launcher properties window disappears when $HOME is on NFS
Product: nautilus
Classification: Core
Component: File Properties Dialog
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Reported: 2009-03-17 12:57 UTC by Timo Aaltonen
Modified: 2009-03-20 07:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

a proposed patch for the kernel (1.67 KB, patch)
2009-03-19 14:45 UTC, Timo Aaltonen
none Details | Review

Description Timo Aaltonen 2009-03-17 12:57:04 UTC
Please describe the problem:
Forwarded from

"To reproduce:
 * create a desktop launcher called test with command /bin/true
 * right click on the launcher and choose "properties"
 * select the "launcher" tab

After about a second the properties window should then disappear.

The launcher still works, and a workaround is to edit ~/Desktop/test.desktop directly using any text editor."

this appears to happen only if $HOME is on NFS and the mount supports locking (ie. using userspace nfs doesn't have this problem).

Steps to reproduce:

Actual results:

Expected results:

Does this happen every time?

Other information:
Comment 1 Alexander Larsson 2009-03-18 15:28:57 UTC
Weird. Would be cool if someone could reproduce this in gdb, with a breakpoint at fm-properties-window.c:real_destroy(). That way we could get a backtrace when this happens and see whats causing it.
Comment 2 Timo Aaltonen 2009-03-19 08:05:45 UTC
Tried that, but it didn't seem to catch it (or I did something wrong):

Breakpoint 1 (fm-properties-window.c:real_destroy()) pending.
(gdb) cont
[New Thread 0x7fdbf4c6b950 (LWP 9052)]
[Thread 0x7fdbf4c6b950 (LWP 9052) exited]
[New Thread 0x7fdbf4c6b950 (LWP 9055)]
[New Thread 0x7fdbf7f3b950 (LWP 9056)]
[Thread 0x7fdbf7f3b950 (LWP 9056) exited]
[New Thread 0x7fdbf7f3b950 (LWP 9059)]
[Thread 0x7fdbf7f3b950 (LWP 9059) exited]
[Thread 0x7fdbf4c6b950 (LWP 9055) exited]
Comment 3 Alexander Larsson 2009-03-19 11:54:32 UTC
Some further irc debugging shows that this happens because clicking on the text-fields will cause the file to be rewritten, which will replace the old file with a new one. And for some reason Timo gets a DELETED notification event from the directory monitor when this happens, which makes nautilus close the property window for the file.

When run here on ext3 I don't get a DELETED event though.
Comment 4 Alexander Larsson 2009-03-19 11:58:47 UTC
Results from mv temp.txt foobar 

Directory Monitor Event:
Child = /mnt/data/temp/foobar
Directory Monitor Event:
Child = /mnt/data/temp/temp.txt
Directory Monitor Event:
Child = /mnt/data/temp/foobar

On ext3:
Directory Monitor Event:
Child = /tmp/x/temp.txt
Directory Monitor Event:
Child = /tmp/x/foobar

This is IMHO bogus behaviour from NFS. At no time is the "foobar" file not visible, so it should IMHO not be reported as deleted.
Comment 5 Alexander Larsson 2009-03-19 12:16:07 UTC
I commited a fix so that the file is not rewritten when the text fields don't actually change, but the problem still exists if they do.
Comment 6 Timo Aaltonen 2009-03-19 14:45:50 UTC
Created attachment 130974 [details] [review]
a proposed patch for the kernel

I already got a propose fix for it (kernel/nfs), but can't test before tomorrow. Attaching here for reference.
Comment 7 Timo Aaltonen 2009-03-20 07:48:49 UTC
I've verified that the attached kernel patch works, so this bug can be closed :)