GNOME Bugzilla – Bug 575683
Banshee should treat disc 0 of 0 equal to disc 1 of 1 when sorting.
Last modified: 2011-10-24 00:15:49 UTC
I recently noted that some songs on one of my albums appeared out of order when displayed in Banshee. Upon further investigation I found that this was because some of the tracks had disc 0 of 0 and others had disc 1 of 1 set in the id3 tag. I would argue that banshee should either write disc 1 of 1 to the id3 tag when it encounters an empty or invalid disc number element in the tag, or should treat disc 0 of 0 equal to disc 1 of 1 when sorting. Of course, if you'd prefer that banshee respect exactly what's in the id3 tag, I understand and please feel free to mark this Wont Fix.
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of 573093 ***
I'm re-opening this, because I think it's a legitimately separate bug. > I would argue that banshee should either write disc 1 of 1 to the id3 tag when > it encounters an empty or invalid disc number element in the tag Some tracks don't belong to a disk, so this would be inserting invalid metadata into a track (we just fixed bug 575683 about that). > or should treat disc 0 of 0 equal to disc 1 of 1 when sorting. This should be safe, though. The only problems I can think of it causing would be for sorting two albums with the same name, and the higher-number album missing its discnumber metadata.
Created attachment 131009 [details] [review] Sort disc-0 tracks as disc-1
I'm not wild about adding extra computation to almost every single sort (you missed default_sort, John) anybody ever does in Banshee to work around some crappy metadata. There are hundreds of situations where we could do that, but if we did it for all of them, our performance would be terrible. I'm sure MAX is quite fast, so maybe you can convince me we should make an exception. Aaron is all about only ever making Banshee faster though, and this doesn't do it. :)
Given comment#4 above, and comment 7 of the dupe 629162, I'm closing this as WONTFIX, please reopen if you think otherwise and have counter-arguments.
*** Bug 629162 has been marked as a duplicate of this bug. ***