GNOME Bugzilla – Bug 575638
kissfft copyright
Last modified: 2009-04-14 16:14:55 UTC
I was pleased to find that gstreamer base plugins are making use of my kiss_fft library. http://sourceforge.net/projects/kissfft I would've been even happier if my copyright notice appeard ;) The binary package (on Fedora 9) does not reproduce any copyright notice for kiss fft. I'm not trying to pretend that I've been active in the gstreamer project, but an honorable mention somewhere would be nice. I understand that the binary rpm(s) in question are made by the Fedora package maintainer, so if I am bringing this up in the wrong forum, I apologize. Thanks for all your hard work. I am sincerely glad you found kiss fft useful. Regards, Mark
Hi, first of all thanks for your great work on kissfft :) Your copyright notice currently is at the top of all source files from you, including licensing information. Where would you like to see your copyright notice additionally? If you just want it in the binary packages the best would be to file a bug at your distribution as they usually maintain a collected list of copyright holders/license information for the sources (at least that's what we're doing for Debian/Ubuntu in theory). If you want we could also add you to the top of the documentation to the fft library with a paragraph like "The gstfft library is based on <a href="http://sourceforge.net/projects/kissfft">kissfft</a> by Mark Borgerding"
Mark: ping? (new -base release coming up soon, would be nice to get this resolved before the release)
I appreciate your understanding. I tried to figure out who to contact about the RPM binary package since that is where this bug report rightly belongs, but it was not clear to me how to contact the Red Hat maintainer. I would certainly not claim "authorship" over gstreamer, but it does seem like the AUTHORS file gets picked up by the downstream packages maintainers. What do you think about a footnote in the AUTHOR file? "Also contains code from kissfft project. Copyright Mark Borgerding. (Revised BSD license)"
I've committed this now: http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=9f23b82b2c428ef757a0566a22dec1e8bc5026ff commit 9f23b82b2c428ef757a0566a22dec1e8bc5026ff Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Tue Apr 14 17:01:51 2009 +0100 Give credit to Mark Borgerding (kissfft author) and add myself to AUTHORS as well. Fixes #575638. Hope that's ok (if not, please re-open) :)