After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575317 - Stop looking at go_format_builtins
Stop looking at go_format_builtins
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2009-03-14 02:17 UTC by Morten Welinder
Modified: 2009-09-25 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morten Welinder 2009-03-14 02:17:36 UTC 
Gnumeric should keep its little hands away from go_format_builtins.
I want that to be for dialog purposes only.

Most importantly, I want to stay away from the date formats, see bug 33229.

welinder@toshiba:~/gnome/gnumeric> find . -name '*.[chy]' -print | xargs grep go_format_builtin
./src/number-match.c:				(go_format_builtins[fam][2]);
./src/wbc-gtk-actions.c:	GOFormat *fmt = go_format_new_from_XL (go_format_builtins[GO_FORMAT_CURRENCY][0]);
./src/wbc-gtk-actions.c:	GOFormat *fmt = go_format_new_from_XL (go_format_builtins[GO_FORMAT_ACCOUNTING][2]);
./plugins/excel/ms-excel-read.c:	excel_builtin_formats [0x0e] = go_format_builtins [GO_FORMAT_DATE][0];
./plugins/excel/ms-excel-read.c:	excel_builtin_formats [0x0f] = go_format_builtins [GO_FORMAT_DATE][2];
./plugins/excel/ms-excel-read.c:	excel_builtin_formats [0x10] = go_format_builtins [GO_FORMAT_DATE][4];
./plugins/excel/ms-excel-read.c:	excel_builtin_formats [0x16] = go_format_builtins [GO_FORMAT_DATE][20];
Comment 1 Morten Welinder 2009-03-15 19:11:22 UTC 
We're down to

./src/wbc-gtk-actions.c:	GOFormat *fmt = go_format_new_from_XL (go_format_builtins[GO_FORMAT_CURRENCY][0]);

This no longer blocks bug 33229.
Comment 2 Morten Welinder 2009-09-25 00:44:57 UTC 
Fixed a while back.