After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575270 - GVolumeMonitor::mount-pre-unmount not being emitted
GVolumeMonitor::mount-pre-unmount not being emitted
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 576104
 
 
Reported: 2009-03-13 17:08 UTC by Carlos Garnacho
Modified: 2009-03-26 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for the gio side (4.25 KB, patch)
2009-03-20 14:14 UTC, Carlos Garnacho 		none Details | Review
Updated patch, don't include the GMount::pre-unmount changes (2.67 KB, patch)
2009-03-20 16:22 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2009-03-13 17:08:16 UTC 
At first I thought it was some glitch in my dev environment, but I upgraded everything involved to latest trunk and still see this.

I you run gvfs-mount -o and unmount some usb stick (either through nautilus or gvfs-mount), the callback for "mount-pre-unmount" isn't ever called.

I'll try to investigate this further...
Comment 1 Carlos Garnacho 2009-03-20 14:14:15 UTC 
Created attachment 131029 [details] [review]
Fix for the gio side
Comment 2 Alexander Larsson 2009-03-20 14:27:46 UTC 
Can you split it out into two patches? That way we can commit somthing to 2.20.1 that emits mount-pre-unmount, and add the GMount::pre-unmount signal in 2.22.
Comment 3 Carlos Garnacho 2009-03-20 14:49:41 UTC 
Sure! doing that now, want me to put the latter in a new bug? I've also submitted bug #576083 for the GVfs side
Comment 4 Carlos Garnacho 2009-03-20 16:22:55 UTC 
Created attachment 131037 [details] [review]
Updated patch, don't include the GMount::pre-unmount changes
Comment 5 Alexander Larsson 2009-03-23 07:00:19 UTC 
Looks good to commit. And no need for a new bug for the rest of the patch.
Comment 6 Carlos Garnacho 2009-03-26 14:02:11 UTC 
Just committed it, thanks! Actually, before comment #5, I already opened bug #576104 to add GMount::pre-unmount, so I'll close this bug.

2009-03-26  Carlos Garnacho  <carlosg@gnome.org>

        Bug 575270 – GVolumeMonitor::mount-pre-unmount not being emitted

        * gunixmount.c (eject_unmount_cb) (eject_unmount_do_cb)
        (eject_unmount_do): Emit ::mount-pre-unmount and wait 500msec before
        actually trying to unmount.